public inbox for cpufreq@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cpufreq: exynos: Show list of available frequencies
@ 2013-01-08 10:50 Inderpal Singh
  2013-01-08 11:00 ` Inderpal Singh
  2013-01-09  4:36 ` [linux-pm] " amit kachhap
  0 siblings, 2 replies; 4+ messages in thread
From: Inderpal Singh @ 2013-01-08 10:50 UTC (permalink / raw)
  To: linux-pm
  Cc: rjw, linux-samsung-soc, linux-kernel, cpufreq, kgene.kim, patches

Add freq_attr attribute to show list of available frequencies.

Signed-off-by: Donggeun Kim <dg77.kim@samsung.com>
Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Signed-off-by: KyungMin Park <kyungmin.park@samsung.com>
Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
---
 drivers/cpufreq/exynos-cpufreq.c |   13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
index 7012ea8..bc1e833 100644
--- a/drivers/cpufreq/exynos-cpufreq.c
+++ b/drivers/cpufreq/exynos-cpufreq.c
@@ -244,13 +244,26 @@ static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy)
 	return cpufreq_frequency_table_cpuinfo(policy, exynos_info->freq_table);
 }
 
+static int exynos_cpufreq_cpu_exit(struct cpufreq_policy *policy)
+{
+	cpufreq_frequency_table_put_attr(policy->cpu);
+	return 0;
+}
+
+static struct freq_attr *exynos_cpufreq_attr[] = {
+	&cpufreq_freq_attr_scaling_available_freqs,
+	NULL,
+};
+
 static struct cpufreq_driver exynos_driver = {
 	.flags		= CPUFREQ_STICKY,
 	.verify		= exynos_verify_speed,
 	.target		= exynos_target,
 	.get		= exynos_getspeed,
 	.init		= exynos_cpufreq_cpu_init,
+	.exit           = exynos_cpufreq_cpu_exit,
 	.name		= "exynos_cpufreq",
+	.attr           = exynos_cpufreq_attr,
 #ifdef CONFIG_PM
 	.suspend	= exynos_cpufreq_suspend,
 	.resume		= exynos_cpufreq_resume,
-- 
1.7.9.5


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] cpufreq: exynos: Show list of available frequencies
  2013-01-08 10:50 [PATCH] cpufreq: exynos: Show list of available frequencies Inderpal Singh
@ 2013-01-08 11:00 ` Inderpal Singh
  2013-01-09  4:36 ` [linux-pm] " amit kachhap
  1 sibling, 0 replies; 4+ messages in thread
From: Inderpal Singh @ 2013-01-08 11:00 UTC (permalink / raw)
  To: linux-pm
  Cc: rjw, linux-samsung-soc, linux-kernel, cpufreq, kgene.kim, patches,
	dg77.kim, MyungJoo Ham, kyungmin.park

+CC:
dg77.kim@samsung.com, myungjoo.ham@samsung.com, kyungmin.park@samsung.com

On 8 January 2013 16:20, Inderpal Singh <inderpal.singh@linaro.org> wrote:
> Add freq_attr attribute to show list of available frequencies.
>
> Signed-off-by: Donggeun Kim <dg77.kim@samsung.com>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: KyungMin Park <kyungmin.park@samsung.com>
> Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
> ---
>  drivers/cpufreq/exynos-cpufreq.c |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
> index 7012ea8..bc1e833 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -244,13 +244,26 @@ static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy)
>         return cpufreq_frequency_table_cpuinfo(policy, exynos_info->freq_table);
>  }
>
> +static int exynos_cpufreq_cpu_exit(struct cpufreq_policy *policy)
> +{
> +       cpufreq_frequency_table_put_attr(policy->cpu);
> +       return 0;
> +}
> +
> +static struct freq_attr *exynos_cpufreq_attr[] = {
> +       &cpufreq_freq_attr_scaling_available_freqs,
> +       NULL,
> +};
> +
>  static struct cpufreq_driver exynos_driver = {
>         .flags          = CPUFREQ_STICKY,
>         .verify         = exynos_verify_speed,
>         .target         = exynos_target,
>         .get            = exynos_getspeed,
>         .init           = exynos_cpufreq_cpu_init,
> +       .exit           = exynos_cpufreq_cpu_exit,
>         .name           = "exynos_cpufreq",
> +       .attr           = exynos_cpufreq_attr,
>  #ifdef CONFIG_PM
>         .suspend        = exynos_cpufreq_suspend,
>         .resume         = exynos_cpufreq_resume,
> --
> 1.7.9.5
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [linux-pm] [PATCH] cpufreq: exynos: Show list of available frequencies
  2013-01-08 10:50 [PATCH] cpufreq: exynos: Show list of available frequencies Inderpal Singh
  2013-01-08 11:00 ` Inderpal Singh
@ 2013-01-09  4:36 ` amit kachhap
  2013-01-18  4:35   ` Kukjin Kim
  1 sibling, 1 reply; 4+ messages in thread
From: amit kachhap @ 2013-01-09  4:36 UTC (permalink / raw)
  To: Inderpal Singh
  Cc: linux-pm, kgene.kim, patches, linux-kernel, cpufreq,
	linux-samsung-soc

On Tue, Jan 8, 2013 at 2:50 AM, Inderpal Singh
<inderpal.singh@linaro.org> wrote:
> Add freq_attr attribute to show list of available frequencies.
>
> Signed-off-by: Donggeun Kim <dg77.kim@samsung.com>
> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> Signed-off-by: KyungMin Park <kyungmin.park@samsung.com>
> Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
> ---
>  drivers/cpufreq/exynos-cpufreq.c |   13 +++++++++++++
>  1 file changed, 13 insertions(+)
>
> diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-cpufreq.c
> index 7012ea8..bc1e833 100644
> --- a/drivers/cpufreq/exynos-cpufreq.c
> +++ b/drivers/cpufreq/exynos-cpufreq.c
> @@ -244,13 +244,26 @@ static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy)
>         return cpufreq_frequency_table_cpuinfo(policy, exynos_info->freq_table);
>  }
>
> +static int exynos_cpufreq_cpu_exit(struct cpufreq_policy *policy)
> +{
> +       cpufreq_frequency_table_put_attr(policy->cpu);
> +       return 0;
> +}
> +
> +static struct freq_attr *exynos_cpufreq_attr[] = {
> +       &cpufreq_freq_attr_scaling_available_freqs,
> +       NULL,
> +};
> +

This change looks fine. I guess this was posted before also but could
not go mainline.
Reviewed-by: Amit Daniel Kachhap<amit.daniel@samsung.com>

Thanks,
Amit Daniel
>  static struct cpufreq_driver exynos_driver = {
>         .flags          = CPUFREQ_STICKY,
>         .verify         = exynos_verify_speed,
>         .target         = exynos_target,
>         .get            = exynos_getspeed,
>         .init           = exynos_cpufreq_cpu_init,
> +       .exit           = exynos_cpufreq_cpu_exit,
>         .name           = "exynos_cpufreq",
> +       .attr           = exynos_cpufreq_attr,
>  #ifdef CONFIG_PM
>         .suspend        = exynos_cpufreq_suspend,
>         .resume         = exynos_cpufreq_resume,
> --
> 1.7.9.5
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [linux-pm] [PATCH] cpufreq: exynos: Show list of available frequencies
  2013-01-09  4:36 ` [linux-pm] " amit kachhap
@ 2013-01-18  4:35   ` Kukjin Kim
  0 siblings, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2013-01-18  4:35 UTC (permalink / raw)
  To: 'amit kachhap', 'Inderpal Singh'
  Cc: linux-pm, patches, linux-kernel, cpufreq, linux-samsung-soc

amit kachhap wrote:
> 
> On Tue, Jan 8, 2013 at 2:50 AM, Inderpal Singh
> <inderpal.singh@linaro.org> wrote:
> > Add freq_attr attribute to show list of available frequencies.
> >
> > Signed-off-by: Donggeun Kim <dg77.kim@samsung.com>
> > Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
> > Signed-off-by: KyungMin Park <kyungmin.park@samsung.com>
> > Signed-off-by: Inderpal Singh <inderpal.singh@linaro.org>
> > ---
> >  drivers/cpufreq/exynos-cpufreq.c |   13 +++++++++++++
> >  1 file changed, 13 insertions(+)
> >
> > diff --git a/drivers/cpufreq/exynos-cpufreq.c b/drivers/cpufreq/exynos-
> cpufreq.c
> > index 7012ea8..bc1e833 100644
> > --- a/drivers/cpufreq/exynos-cpufreq.c
> > +++ b/drivers/cpufreq/exynos-cpufreq.c
> > @@ -244,13 +244,26 @@ static int exynos_cpufreq_cpu_init(struct
> cpufreq_policy *policy)
> >         return cpufreq_frequency_table_cpuinfo(policy, exynos_info-
> >freq_table);
> >  }
> >
> > +static int exynos_cpufreq_cpu_exit(struct cpufreq_policy *policy)
> > +{
> > +       cpufreq_frequency_table_put_attr(policy->cpu);
> > +       return 0;
> > +}
> > +
> > +static struct freq_attr *exynos_cpufreq_attr[] = {
> > +       &cpufreq_freq_attr_scaling_available_freqs,
> > +       NULL,
> > +};
> > +
> 
> This change looks fine. I guess this was posted before also but could
> not go mainline.
> Reviewed-by: Amit Daniel Kachhap<amit.daniel@samsung.com>
> 
Looks OK to me, applied.

Thanks.

- Kukjin


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2013-01-18  4:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-01-08 10:50 [PATCH] cpufreq: exynos: Show list of available frequencies Inderpal Singh
2013-01-08 11:00 ` Inderpal Singh
2013-01-09  4:36 ` [linux-pm] " amit kachhap
2013-01-18  4:35   ` Kukjin Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox