From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Revell Subject: Re: [PATCH] CPU frequency display in /proc/cpuinfo Date: Sun, 04 Dec 2005 14:49:26 -0500 Message-ID: <1133725767.19768.12.camel@mindpipe> References: <20051202181927.GD9766@wotan.suse.de> <20051202104320.A5234@unix-os.sc.intel.com> <20051204164335.GB32492@isilmar.linta.de> <20051204183239.GE14247@wotan.suse.de> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20051204183239.GE14247@wotan.suse.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: cpufreq-bounces@lists.linux.org.uk Errors-To: cpufreq-bounces+glkc-cpufreq=gmane.org+glkc-cpufreq=gmane.org@lists.linux.org.uk Content-Type: text/plain; charset="us-ascii" To: Andi Kleen Cc: Andrew Morton , Dave Jones , cpufreq , linux-kernel On Sun, 2005-12-04 at 19:32 +0100, Andi Kleen wrote: > On Sun, Dec 04, 2005 at 05:43:35PM +0100, Dominik Brodowski wrote: > > On Fri, Dec 02, 2005 at 10:43:20AM -0800, Venkatesh Pallipadi wrote: > > > The patch below changes this to: > > > Show the last known frequency of the particular CPU, when cpufreq is present. If > > > cpu doesnot support changing of frequency through cpufreq, then boot frequency > > > will be shown. The patch affects i386, x86_64 and ia64 architectures. > > > > Looks good to me -- however, might this affect userspace cpufreq tools? I'd > > They normally use /sys anyways. Wrong, lots of userspace programs that need to know the CPU speed get it from /proc/cpuinfo. It would be nice if there were a better API. As long as you don't change the file format it should be OK. Lee