cpufreq.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@dominikbrodowski.net>
To: cpufreq@vger.kernel.org
Cc: Thomas Renninger <trenn@suse.de>,
	Dominik Brodowski <linux@dominikbrodowski.net>
Subject: [PATCH 06/13] cpupower: Remove unneeded code and by that fix a memleak
Date: Sun, 25 Mar 2012 20:38:47 +0200	[thread overview]
Message-ID: <1332700734-26435-6-git-send-email-linux@dominikbrodowski.net> (raw)
In-Reply-To: <1332700734-26435-1-git-send-email-linux@dominikbrodowski.net>

From: Thomas Renninger <trenn@suse.de>

Looks like some not needed debug code slipped in.
Also this code:
tmp = sysfs_get_idlestate_name(cpu, idlestates - 1);
performs a strdup and the mem was not freed again.
-> delete it.

Signed-off-by: Thomas Renninger <trenn@suse.de>
Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net>
---
 tools/power/cpupower/utils/cpuidle-info.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)

diff --git a/tools/power/cpupower/utils/cpuidle-info.c b/tools/power/cpupower/utils/cpuidle-info.c
index e076beb..8145af5 100644
--- a/tools/power/cpupower/utils/cpuidle-info.c
+++ b/tools/power/cpupower/utils/cpuidle-info.c
@@ -35,13 +35,6 @@ static void cpuidle_cpu_output(unsigned int cpu, int verbose)
 		printf(_("CPU %u: Can't read idle state info\n"), cpu);
 		return;
 	}
-	tmp = sysfs_get_idlestate_name(cpu, idlestates - 1);
-	if (!tmp) {
-		printf(_("Could not determine max idle state %u\n"),
-		       idlestates - 1);
-		return;
-	}
-
 	printf(_("Number of idle states: %d\n"), idlestates);
 	printf(_("Available idle states:"));
 	for (idlestate = 0; idlestate < idlestates; idlestate++) {
-- 
1.7.5.4


  parent reply	other threads:[~2012-03-25 18:38 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-25 18:38 [git pull] cpupowerutils updates for 3.4 Dominik Brodowski
2012-03-25 18:38 ` [PATCH 01/13] cpupower: Better interface for accessing AMD pci registers Dominik Brodowski
2012-03-25 18:38   ` [PATCH 02/13] cpupower: AMD fam14h/Ontario monitor can also be used by fam12h cpus Dominik Brodowski
2012-03-25 18:38   ` [PATCH 03/13] cpupower: Add cpupower-idle-info manpage Dominik Brodowski
2012-03-25 18:38   ` [PATCH 04/13] cpupower: Unify cpupower-frequency-* manpages Dominik Brodowski
2012-03-25 18:38   ` [PATCH 05/13] cpupower: Fix number of idle states Dominik Brodowski
2012-03-25 18:38   ` Dominik Brodowski [this message]
2012-03-25 18:38   ` [PATCH 07/13] cpupower: Fix linking with --as-needed Dominik Brodowski
2012-03-25 18:38   ` [PATCH 08/13] cpupower tool: remove use of undefined variables from the clean target of the top makefile Dominik Brodowski
2012-03-25 18:38   ` [PATCH 09/13] cpupower tool: makefile: simplify the recipe used to generate cpupower.pot target Dominik Brodowski
2012-03-25 18:38   ` [PATCH 10/13] cpupower tool: allow to build in a separate directory Dominik Brodowski
2012-03-25 18:38   ` [PATCH 11/13] cpupower: Fix broken mask values Dominik Brodowski
2012-03-25 18:38   ` [PATCH 12/13] cpupower tools: allow to build debug tools in a separate directory too Dominik Brodowski
2012-03-25 18:38   ` [PATCH 13/13] cpupower tools: add install target to the debug tools' makefiles Dominik Brodowski
2012-03-29  5:23 ` [git pull] cpupowerutils updates for 3.4 Dominik Brodowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1332700734-26435-6-git-send-email-linux@dominikbrodowski.net \
    --to=linux@dominikbrodowski.net \
    --cc=cpufreq@vger.kernel.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).