From: dirk.brandewie@gmail.com
To: linux-kernel@vger.kernel.org, cpufreq@vger.kernel.org
Cc: Dirk Brandewie <dirk.j.brandewie@intel.com>
Subject: [PATCH 2/6] cpufreq: Only query drivers that implement cpufreq_driver.target()
Date: Fri, 1 Feb 2013 10:45:37 -0800 [thread overview]
Message-ID: <1359744343-18690-4-git-send-email-dirk.brandewie@gmail.com> (raw)
In-Reply-To: <1359744343-18690-1-git-send-email-dirk.brandewie@gmail.com>
From: Dirk Brandewie <dirk.j.brandewie@intel.com>
Scaling drivers that implement cpufreq_driver.setpolicy() have
internal governors and may/will change the current operating frequency
very frequently this will cause cpufreq_out_of_sync() to be called
every time. Only call cpufreq_driver.get() for drivers that implement
cpufreq_driver.target()
Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
---
drivers/cpufreq/cpufreq.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 1c037f0..493cd50 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1794,7 +1794,7 @@ int cpufreq_update_policy(unsigned int cpu)
/* BIOS might change freq behind our back
-> ask driver for current freq and notify governors about a change */
- if (cpufreq_driver->get) {
+ if (cpufreq_driver->get && cpufreq_driver->target) {
policy.cur = cpufreq_driver->get(cpu);
if (!data->cur) {
pr_debug("Driver did not initialize current freq");
--
1.7.7.6
next prev parent reply other threads:[~2013-02-01 18:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 18:45 [PATCH 0/6] Add P state driver for Intel Core Processors dirk.brandewie
2013-02-01 18:45 ` [PATCH 1/6] cpufreq: Retrieve current frequency from scaling drivers with internal governors dirk.brandewie
2013-02-01 18:45 ` [PATCH 2/6] cpufreq: Only query drivers that implement cpufreq_driver.target() dirk.brandewie
2013-02-02 3:22 ` Viresh Kumar
2013-02-01 18:45 ` dirk.brandewie [this message]
2013-02-01 18:45 ` [PATCH 3/6] cpufreq: Do not track governor name for scaling drivers with internal governors dirk.brandewie
2013-02-02 3:25 ` Viresh Kumar
[not found] ` <CANOOhLSSXPuLG5X=TCfThjwcR3GuR=Z-O5qmY4StJZzg+Er5tA@mail.gmail.com>
2013-02-02 5:54 ` Viresh Kumar
2013-02-01 18:45 ` dirk.brandewie
2013-02-01 18:45 ` [PATCH 4/6] cpufreq_stats: Do not track policies without associated governors dirk.brandewie
2013-02-02 5:38 ` Viresh Kumar
2013-02-01 18:45 ` dirk.brandewie
2013-02-01 18:45 ` [PATCH 5/6] cpufreq: balance out cpufreq_cpu_{get,put} for scaling drivers using setpolicy dirk.brandewie
2013-02-02 5:41 ` Viresh Kumar
2013-02-04 18:25 ` Dirk Brandewie
2013-02-05 7:03 ` Viresh Kumar
2013-02-01 18:45 ` [PATCH 6/6] cpufreq/x86: Add P-state driver for sandy bridge dirk.brandewie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1359744343-18690-4-git-send-email-dirk.brandewie@gmail.com \
--to=dirk.brandewie@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=dirk.j.brandewie@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox