Re: [PATCH v3 2/2] cpufreq: tegra: Re-model Tegra cpufreq driver

bilhuang
2013-12-19T05:26:47Z

On 12/18/2013 10:39 PM, Viresh Kumar wrote:
> On 18 December 2013 17:03, bilhuang <bilhuang@nvidia.com> wrote:
>> cpufreq-cpu0 driver will call regulator_set_voltage_tol() directly according
>> to the pre-defined OPP freq/volt pairs, the regulator drivers could be
>> shared by other SoC so is not suitable to handle this, or do I
>> misunderstand?
>
> In case regulator's driver is shared, then you can probably add another
> virtual regulator for CPU which would have the special code you want.
>
I'm not sure virtual regulator for CPU is a good idea, in addition to
that, we don't have a single SoC OPP table, we need several which are
speedo-id and process-id dependant, but generic cpufreq-cpu0 is assuming
there is only one statically, for some SoC the frequency table is not
fixed, they are created at runtime combining our fast and slow CPU
frequency table and dvfs table. So I'm really not sure is it worth
adding so many tweaks in order to use the generic cpufreq-cpu0 driver.