From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: [PATCH] cpufreq: Reformat printk() statement Date: Mon, 10 Mar 2014 09:49:18 -0700 Message-ID: <1394470158.24244.18.camel@joe-AO722> References: <1394127279-29871-1-git-send-email-soren.brinkmann@xilinx.com> <1394424432.30791.11.camel@joe-AO722> Mime-Version: 1.0 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: cpufreq-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="iso-8859-1" To: =?ISO-8859-1?Q?S=F6ren?= Brinkmann Cc: Viresh Kumar , "cpufreq@vger.kernel.org" , Linux Kernel Mailing List , "linux-pm@vger.kernel.org" On Mon, 2014-03-10 at 09:35 -0700, S=F6ren Brinkmann wrote: > Hi Joe, Hello S=F6ren: > On Sun, 2014-03-09 at 09:07PM -0700, Joe Perches wrote: > > On Mon, 2014-03-10 at 11:53 +0800, Viresh Kumar wrote: > > > On 7 March 2014 01:34, Soren Brinkmann wrote: > > > > Reformat a printk statement to: > > > > - use pr_warn > > > > - bring the whole string into a single line in favor of being = able to > > > > grep for the message (ignoring the 80 char limit) > > > > > > > > Signed-off-by: Soren Brinkmann > > [] > > > Acked-by: Viresh Kumar > >=20 > > A more comprehensive patch would be to: > >=20 > > Add missing newlines > > Coalesce format fragments > > Convert printks to pr_ > > Align arguments >=20 > I agree. But I didn't want to spend time on "fixing" formatting witho= ut > knowing it will be accepted. Also, I was grepping for the message I > ended up changing because on an issue I actually needed to fix. >=20 > Do you want me to squash your changes into the patch I submitted? Or = do > you wanna pick up mine and submit your patch? What I sent incorporates your change. If Viresh or Rafael want me to sign it, I will, Original-patch-by: S=F6ren Brinkmann Signed-off-by: Joe Perches otherwise, feel free to resend it with your signature. cheers, Joe