RE: [PATCH] cpufreq: fix garbage kobj on errors during suspend/resume

Jarzmik, Robert
2013-12-24T09:46:38Z

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="us-ascii", Size: 1854 bytes --]

> -----Original Message-----
> From: Srivatsa S. Bhat [mailto:srivatsa.bhat@linux.vnet.ibm.com]
> Sent: Wednesday, December 4, 2013 07:24
> To: Bjørn Mork
> Cc: cpufreq@vger.kernel.org; linux-pm@vger.kernel.org; Viresh Kumar;
> Wysocki, Rafael J; Jarzmik, Robert; R, Durgadoss
> Subject: Re: [PATCH] cpufreq: fix garbage kobj on errors during
> suspend/resume
>
> > It is therefore
> > best to revert the patch enabling this code until the error handling
> > is in place.
Agreed.

> I agree, that's a good decision. I'll take a look at it later to see if we
> can restructure the code to include proper error handling in all the
> failure paths. If that gets way out of control in terms of complexity,
> then its probably best to drop this "feature" altogether. It has caused
> enough problems already, and the initial motivation behind doing that
> doesn't seem to be that strong now (CC'ing Robert and Durga).

Well, the motivation is still the same I think, ie. making thermal management
work, but that's not as important as a broken hibernation.

And in the long term, if I understood correctly that it's the suspend error
path with "stale" kobjects which is the problem, then this will have to be
addressed sooner or later, won't it ?

Cheers.

--
Robert

---------------------------------------------------------------------
Intel Corporation SAS (French simplified joint stock company)
Registered headquarters: "Les Montalets"- 2, rue de Paris,
92196 Meudon Cedex, France
Registration Number: 302 456 199 R.C.S. NANTERRE
Capital: 4,572,000 Euros

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.