Re: 2.6.0-test1 CpuFreq Speedstep Quirks

[Dominik Brodowski <linux@brodo.de>]

[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]

Hi Mike,

Many thanks for your extensive bug report. Could you please try out the
following:

a) test the attached patch

b) if this didn't help, boot with "clock=pit"

	Dominik


On Thu, Jul 17, 2003 at 02:48:42PM +0000, Michael Vallaly wrote:
> 
> 
> Hello, 
> 
> After testing the 2.6.0-test1 kernel with CPUfreq scaling compiled in (+userspace govenor) I have noticed some changes in the way the kernel detects and prints my CPU information. Along these lines some programs (in peticular, mplayer and xmms) have some issues syncing (apparently time critical / cpu speed critical code.) As of right now these issues only seem to disappear if I run in powersave mode. Im not quite sure if this is a bug or not as I am quite new to cpu frequency scaling issues. If this is no
> t a bug / problem maybe someone can help enlighten me as to what is actually occuring. I would be willing to test anything speedstep / cpufreq related as I have quite a bit of freetime until August 25th. Attached are few screenshots of the interesting quirks with Cpufreq installed. Thanks for you time..
> 
> - Mike
> 
> 
> Michael Vallaly
> vaio@nolatency.com
> 
> 
> 



[-- Attachment #2: cpufreq-2.6.0-test1-speedstep-fix_setspeed --]
[-- Type: text/plain, Size: 1207 bytes --]

Correct the notification of the cpufreq core of the new frequency being 
set in ich's speedstep_set, and print accurate debug info in this function.
(both bugs noted by Valdis Kletnieks, thanks!)

 arch/i386/kernel/cpu/cpufreq/speedstep-ich.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- linux/arch/i386/kernel/cpu/cpufreq/speedstep-ich.c.original	2003-07-14 23:26:42.415960752 +0200
+++ linux/arch/i386/kernel/cpu/cpufreq/speedstep-ich.c	2003-07-14 23:29:42.624564880 +0200
@@ -82,7 +82,7 @@
 		return;
 
 	freqs.old = speedstep_get_processor_frequency(speedstep_processor);
-	freqs.new = speedstep_freqs[SPEEDSTEP_LOW].frequency;
+	freqs.new = speedstep_freqs[state].frequency;
 	freqs.cpu = 0; /* speedstep.c is UP only driver */
 	
 	if (notify)
@@ -137,7 +137,7 @@
 	dprintk(KERN_DEBUG "cpufreq: read at pmbase 0x%x + 0x50 returned 0x%x\n", pmbase, value);
 
 	if (state == (value & 0x1)) {
-		dprintk (KERN_INFO "cpufreq: change to %u MHz succeeded\n", (freqs.new / 1000));
+		dprintk (KERN_INFO "cpufreq: change to %u MHz succeeded\n", (speedstep_get_processor_frequency(speedstep_processor) / 1000));
 	} else {
 		printk (KERN_ERR "cpufreq: change failed - I/O error\n");
 	}