Re: [RFC] cpufreq_driver->resume

[Dominik Brodowski <linux@brodo.de>]

On Tue, Sep 02, 2003 at 12:08:26PM +0100, Dave Jones wrote:
> 
> On Tue, Sep 02, 2003 at 10:32:27AM +0200, Dominik Brodowski wrote:
> 
>  > +cpufreq_driver.resume -		A pointer to a per-CPU resume function
>  > +				which is called with interrupts disabled
>  > +				and _before_ the pre-suspend frequency
>  > +				and/or policy is restored by a call to
>  > +				->target or ->setpolicy.
>  > +
> 
> What advantage is there to doing things this way over just
> setting the speed to the last known value before we suspended ?
> (though some drivers may need fixing, as they shortcut the
>  'trying to set to current speed' thing with a return so we
>  don't actually poke anything.)

Check the speedstep_smi driver -- it needs to pass a value to the BIOS after
every resume sequence. It was done there using a pm_dev, the generic/new
->resume callback seems to be better suited for this.

	Dominik