cpufreq Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dominik Brodowski <linux@brodo.de>
To: cpufreq@www.linux.org.uk
Subject: [RFC] split up cpufreq.c in several files, x86 autoloader
Date: Sat, 4 Oct 2003 00:36:12 +0200	[thread overview]
Message-ID: <20031003223612.GA18181@brodo.de> (raw)

I've a patch ready which splits up drivers/cpufreq/cpufreq.c into several
files. Instead of

-rw-r--r--    1 linux    users       26014 2003-10-03 23:31 cpufreq.c

it's this:

-rw-r--r--    1 linux    users       11625 2003-10-04 00:17 cpufreq_core.c
	driver and device {un}registration. Can be split up further if
	there's need to do so

-rw-r--r--    1 linux    users        2832 2003-10-04 00:10 cpufreq_governor.c
	cpufreq_governor and friends, and governor {un}registration

-rw-r--r--    1 linux    users        1221 2003-10-04 00:19 cpufreq.h
	prototypes for shared variables and functions

-rw-r--r--    1 linux    users        4913 2003-10-04 00:13 cpufreq_notifiers.c
	cpufreq notifier lists

-rw-r--r--    1 linux    users        7576 2003-10-04 00:14 cpufreq_sysfs.c
	cpufreq sysfs and kobject handling



What's the general opinion about such a split-up?

And what does the public think about this:
Except for a small part [cpufreq_notifiers.c] the rest of the cpufreq core
could be built as a module. drivers/acpi/processor.ko would depend on it,
though [until my ACPI patches are accepted, at least], and it couldn't be
available for a certain ARM architecture IIRC. For x86, it'd make life,
testing, and developing easier.


Third, and last question:
For x86 there is a wide choice of cpufreq drivers. Especially for
distributions and inexperienced users [no pun intended] it might become more
and more difficult to select the best driver: "I got a mobile Pentium-4-M,
p4-clockmod or speedstep-ich?" is one good example. Should the detection of
the "best" cpufreq driver be made available as an optional(!)
"cpufreq-autoload" module in arch/i386/kernel/cpu/cpufreq/?

	Dominik

             reply	other threads:[~2003-10-03 22:36 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-10-03 22:36 Dominik Brodowski [this message]
2003-10-03 23:23 ` [RFC] split up cpufreq.c in several files, x86 autoloader AthlonRob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031003223612.GA18181@brodo.de \
    --to=linux@brodo.de \
    --cc=cpufreq@www.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox