From: Dominik Brodowski <linux@brodo.de>
To: Dave Jones <davej@redhat.com>
Cc: cpufreq@www.linux.org.uk
Subject: Re: [PATCH 5/8] p4_clockmod: detect speed without relying on cpu_khz or user input
Date: Thu, 20 Nov 2003 19:33:35 +0100 [thread overview]
Message-ID: <20031120183335.GB4425@brodo.de> (raw)
In-Reply-To: <20031119190946.GB5653@redhat.com>
On Wed, Nov 19, 2003 at 07:09:46PM +0000, Dave Jones wrote:
>
> patch 4/8 introduced what seems to be the exact same code in the speedstep-lib.
> Perhaps it belongs in an fsb.o instead that they can both share ?
> I don't mind duplicating it twice in object code, but having two copies
> in the source seems a bit silly.
Usually, I agree to this topic. However, I don't want to create just another
file for just this function, and it doesn't belong to speedstep-lib either
as a plain p4 isn't a valid processor for speedstep-lib. So I'd prefer to
have this source code duplication as an exception here.
Dominik
next prev parent reply other threads:[~2003-11-20 18:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-19 18:32 [PATCH 5/8] p4_clockmod: detect speed without relying on cpu_khz or user input Dominik Brodowski
2003-11-19 19:09 ` Dave Jones
2003-11-20 18:33 ` Dominik Brodowski [this message]
2003-11-21 2:26 ` Dave Jones
2003-11-21 9:56 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031120183335.GB4425@brodo.de \
--to=linux@brodo.de \
--cc=cpufreq@www.linux.org.uk \
--cc=davej@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox