From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Dominik Brodowski <linux@dominikbrodowski.de>
Cc: davej@redhat.com, cpufreq@www.linux.org.uk
Subject: Re: [PATCH] fix cpufreq_update_policy
Date: Wed, 28 Jan 2004 17:12:30 -0500 [thread overview]
Message-ID: <200401281712.30477.dtor_core@ameritech.net> (raw)
In-Reply-To: <20040128215249.GA4727@dominikbrodowski.de>
On Wednesday 28 January 2004 04:52 pm, Dominik Brodowski wrote:
> Fix a brown paper bug in drivers/cpufreq/cpufreq.c which accessed
> random memory instead of the correct struct.
>
> Please apply,
>
> diff -ruN linux-original/drivers/cpufreq/cpufreq.c
> linux/drivers/cpufreq/cpufreq.c ---
> linux-original/drivers/cpufreq/cpufreq.c 2004-01-16 20:30:59.000000000
> +0100 +++ linux/drivers/cpufreq/cpufreq.c 2004-01-28 22:16:38.099398456
> +0100 @@ -868,7 +868,7 @@
> down(&data->lock);
>
> memcpy(&policy,
> - &data,
> + data,
> sizeof(struct cpufreq_policy));
> policy.min = data->user_policy.min;
> policy.max = data->user_policy.max;
Why not change it to:
policy = *data;
?
--
Dmitry
next prev parent reply other threads:[~2004-01-28 22:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-28 21:52 [PATCH] fix cpufreq_update_policy Dominik Brodowski
2004-01-28 22:12 ` Dmitry Torokhov [this message]
2004-01-28 22:16 ` Dominik Brodowski
2004-01-29 0:24 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200401281712.30477.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=cpufreq@www.linux.org.uk \
--cc=davej@redhat.com \
--cc=linux@dominikbrodowski.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox