From: Dave Jones <davej@redhat.com>
To: Bruno Ducrot <ducrot@poupinou.org>
Cc: davej@codemonkey.org.uk, cpufreq@www.linux.org.uk
Subject: Re: [PATCH] powernow-k7: example use for powernow_acpi_init()
Date: Mon, 22 Mar 2004 09:51:35 +0000 [thread overview]
Message-ID: <20040322095135.GD29733@redhat.com> (raw)
In-Reply-To: <20040322093851.GO28592@poupinou.org>
On Mon, Mar 22, 2004 at 10:38:51AM +0100, Bruno Ducrot wrote:
>
> This is an example for using the powernow-k7 ACPI perflib integration,
> when the legacy PSB/PST tables are broken.
>
> - printk (KERN_INFO PFX "This is indicative of a broken BIOS.\n");
> - printk (KERN_INFO PFX "See http://www.codemonkey.org.uk/projects/cpufreq/powernow-k7.shtml\n");
> - return -EINVAL;
> + ret = powernow_acpi_init();
> + if (ret) {
> + printk (KERN_INFO PFX "No PST tables match this cpuid (0x%x)\n", etuple);
> + printk (KERN_INFO PFX "This is indicative of a broken BIOS.\n");
> + printk (KERN_INFO PFX "See http://www.codemonkey.org.uk/projects/cpufreq/powernow-k7.shtml\n");
> + }
> + return ret;
> }
> p++;
> }
Looks good, though also mentioning that the acpi fallback failed is probably
a good idea too.
Dave
next prev parent reply other threads:[~2004-03-22 9:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-22 9:25 [PATCH] powernow-k7: acpi support Bruno Ducrot
2004-03-22 9:38 ` [PATCH] powernow-k7: example use for powernow_acpi_init() Bruno Ducrot
2004-03-22 9:51 ` Dave Jones [this message]
2004-03-22 12:36 ` Bruno Ducrot
2004-03-22 12:43 ` [PATCH] powernow-k7: stupid bug in a printk introduced Bruno Ducrot
2004-03-22 14:27 ` [PATCH] powernow-k7: example use for powernow_acpi_init() Dave Jones
2004-03-22 18:23 ` Bruno Ducrot
2004-03-22 18:25 ` Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040322095135.GD29733@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@www.linux.org.uk \
--cc=davej@codemonkey.org.uk \
--cc=ducrot@poupinou.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox