From: Dave Jones <davej@redhat.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Andrew Morton <akpm@osdl.org>, Bruno Ducrot <ducrot@poupinou.org>,
mark.langsdorf@amd.com,
Cpufreq mailing list <cpufreq@www.linux.org.uk>,
paul.devriendt@amd.com,
Dominik Brodowski <linux@dominikbrodowski.de>
Subject: Re: powernow-k8: support acpi
Date: Fri, 2 Apr 2004 10:02:20 +0100 [thread overview]
Message-ID: <20040402090220.GF24789@redhat.com> (raw)
In-Reply-To: <20040402083038.GA307@elf.ucw.cz>
On Fri, Apr 02, 2004 at 10:30:38AM +0200, Pavel Machek wrote:
> > First off, apologies for sitting on this for so long.
> > I just made a first-pass attempt at merging this. Most of
> > (maybe all?) the simpler bits are in (whitespace changes, typos etc).
> > I'll push that out to bkbits soon, so the powernow-k8 diff in the
> > next -mm that Andrew builds should be slightly smaller at least.
>
> Adding of data->, too? Could you mail me your latest powernow-k8.[ch]?
I'll look at that today. (Honest, as soon as I'm done with mail 8-)
> > > +#endif /* CONFIG_X86_POWERNOW_K8_ACPI */
> >
> > This bit just looks *wrong* to me. This looks like something
> > that really should be sorted out in Kconfig.
>
> No problem... Or perhaps just CONFIG_X86_POWERNOW_K8_ACPI should be
> replaced with CONFIG_ACPI in the driver?
Hmm, possibly. Lets see Bruno's response first.
Dave
next prev parent reply other threads:[~2004-04-02 9:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <99F2150714F93F448942F9A9F112634C1163C8D7@txexmtae.amd.com>
[not found] ` <20040321185417.GA7969@dominikbrodowski.de>
2004-03-26 12:29 ` powernow-k8: support acpi Pavel Machek
2004-04-01 23:56 ` Dave Jones
2004-04-02 8:30 ` Pavel Machek
2004-04-02 9:02 ` Dave Jones [this message]
2004-04-02 11:13 ` Dave Jones
2004-04-02 16:24 ` Bruno Ducrot
2004-04-02 16:39 ` Dave Jones
2004-04-02 17:09 ` Pavel Machek
2004-04-06 13:07 ` Dave Jones
2004-04-06 14:55 ` Dominik Brodowski
2004-04-06 15:47 ` Dave Jones
2004-04-06 16:55 ` Dominik Brodowski
2004-04-06 17:05 ` Dave Jones
2004-04-06 21:57 ` Dominik Brodowski
2004-04-08 13:11 ` Pavel Machek
2004-04-02 16:39 ` Dominik Brodowski
2004-04-02 16:46 ` Dominik Brodowski
2004-04-02 16:59 paul.devriendt
2004-04-02 18:40 ` Bruno Ducrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040402090220.GF24789@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=cpufreq@www.linux.org.uk \
--cc=ducrot@poupinou.org \
--cc=linux@dominikbrodowski.de \
--cc=mark.langsdorf@amd.com \
--cc=paul.devriendt@amd.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox