cpufreq Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: Bruno Ducrot <ducrot@poupinou.org>
Cc: cpufreq@www.linux.org.uk
Subject: Re: [PATCH][powernow-k7] correcting SGTC. Timer is based upon FSB.
Date: Wed, 14 Apr 2004 14:31:17 +0100	[thread overview]
Message-ID: <20040414133117.GI24970@redhat.com> (raw)
In-Reply-To: <20040414132854.GE8953@poupinou.org>

On Wed, Apr 14, 2004 at 03:28:54PM +0200, Bruno Ducrot wrote:
 > On Wed, Apr 14, 2004 at 02:18:57PM +0200, Bruno Ducrot wrote:
 > > * Integrate acpi perflib from Dominik.
 > > * Use acpi if the PST tables are known to be broken (ASUS Aspire match one PST,
 > >   but give brain damaged values), or use ACPI if no PST found.
 > > 
 > >  arch/i386/kernel/cpu/cpufreq/powernow-k7.c |  180 +++++++++++++++++++++++++++--
 > >  1 files changed, 168 insertions(+), 12 deletions(-)
 > > 
 > > --- linux-dj-cpufreq/arch/i386/kernel/cpu/cpufreq/powernow-k7.c	2004/04/14 11:49:44	1.3
 > > +++ linux-dj-cpufreq/arch/i386/kernel/cpu/cpufreq/powernow-k7.c	2004/04/14 12:11:24
 > ....
 > 
 > > @@ -341,8 +480,14 @@ static int powernow_decode_bios (int max
 > >  			}
 > >  			printk (KERN_INFO PFX "No PST tables match this cpuid (0x%x)\n", etuple);
 > >  			printk (KERN_INFO PFX "This is indicative of a broken BIOS.\n");
 > > -			printk (KERN_INFO PFX "See http://www.codemonkey.org.uk/projects/cpufreq/powernow-k7.shtml\n");
 > > -			return -EINVAL;
 > > +
 > > +			printk (KERN_INFO PFX "Trying ACPI perflib\n");
 > > +			ret = powernow_acpi_init();
 > > +			if (ret) {
 > > +				printk (KERN_INFO PFX "ACPI and legacy methods failed\n");
 > > +				printk (KERN_INFO PFX "See http://www.codemonkey.org.uk/projects/cpufreq/powernow-k7.shtml\n");
 > > +			}
 > > +			return ret;
 > >  		}
 > >  		p++;
 > >  	}
 > 
 > 
 > This chunk is wrong, because I handle that at powernow_cpu_init() now.
 > Just removing that one should be OK.  Do you want I resend the whole
 > patch, or only that part ?

oops. just send me a patch backing out that bit..

		Dave

  reply	other threads:[~2004-04-14 13:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-14 10:36 [PATCH][powernow-k7] correcting SGTC. Timer is based upon FSB Bruno Ducrot
2004-04-14 10:41 ` Dave Jones
2004-04-14 12:18   ` Bruno Ducrot
2004-04-14 12:23     ` Dave Jones
2004-04-14 12:47       ` Bruno Ducrot
2004-04-14 13:28     ` Bruno Ducrot
2004-04-14 13:31       ` Dave Jones [this message]
2004-04-14 13:52         ` Bruno Ducrot
2004-04-14 17:44     ` Dave Jones
2004-04-14 18:48       ` Dominik Brodowski
2004-04-14 18:58       ` Bruno Ducrot
2004-04-14 19:19         ` Dominik Brodowski
2004-04-15  8:45           ` Bruno Ducrot
2004-04-14 19:02       ` Dominik Brodowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040414133117.GI24970@redhat.com \
    --to=davej@redhat.com \
    --cc=cpufreq@www.linux.org.uk \
    --cc=ducrot@poupinou.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox