From: Bruno Ducrot <ducrot@poupinou.org>
To: cpufreq@www.linux.org.uk
Cc: davej@redhat.com
Subject: Re: Problem powernow an Athlon 2600+ XP[solved]
Date: Thu, 27 May 2004 12:28:05 +0200 [thread overview]
Message-ID: <20040527102805.GR4933@poupinou.org> (raw)
In-Reply-To: <20040527093942.GA8235@dominikbrodowski.de>
On Thu, May 27, 2004 at 11:39:42AM +0200, Dominik Brodowski wrote:
> On Thu, May 27, 2004 at 11:28:38AM +0200, Bruno Ducrot wrote:
> > On Wed, May 26, 2004 at 11:42:38PM +0200, Forcarlo wrote:
> > > "powernow_k7.powernow_acpi_force=1", "powernow_k7.acpi_force=1" don't work.
>
> BTW, how about avoiding the double "powernow" in the module parameter? The
> description
> MODULE_PARM_DESC(acpi_force, "Force ACPI to be used");
>
> also only mentions "acpi_force" instead of "powernow_acpi_force".
You are indeed correct..
--- arch/i386/kernel/cpu/cpufreq/powernow-k7.c 2004/05/19 15:50:50 1.1
+++ arch/i386/kernel/cpu/cpufreq/powernow-k7.c 2004/05/27 10:25:23
@@ -95,7 +95,7 @@
* configuration purpose.
*/
-static int powernow_acpi_force;
+static int acpi_force;
static struct cpufreq_frequency_table *powernow_table;
@@ -558,7 +558,7 @@
}
dprintk(KERN_INFO PFX "FSB: %3d.%03d MHz\n", fsb/1000, fsb%1000);
- if ((dmi_broken & BROKEN_CPUFREQ) || powernow_acpi_force) {
+ if ((dmi_broken & BROKEN_CPUFREQ) || acpi_force) {
printk (KERN_INFO PFX "PSB/PST known to be broken. Trying ACPI instead\n");
result = powernow_acpi_init();
} else {
@@ -638,7 +638,7 @@
kfree(powernow_table);
}
-module_param(powernow_acpi_force, int, 0444);
+module_param(acpi_force, int, 0444);
MODULE_PARM_DESC(acpi_force, "Force ACPI to be used");
--
Bruno Ducrot
-- Which is worse: ignorance or apathy?
-- Don't know. Don't care.
next prev parent reply other threads:[~2004-05-27 10:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-26 21:42 Problem powernow an Athlon 2600+ XP[solved] Forcarlo
2004-05-27 9:28 ` Bruno Ducrot
2004-05-27 9:39 ` Dominik Brodowski
2004-05-27 10:28 ` Bruno Ducrot [this message]
2004-05-27 10:30 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040527102805.GR4933@poupinou.org \
--to=ducrot@poupinou.org \
--cc=cpufreq@www.linux.org.uk \
--cc=davej@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox