From: Dave Jones <davej@redhat.com>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>,
cpufreq@www.linux.org.uk
Subject: Re: post-OLS pending cpufreq patches
Date: Tue, 3 Aug 2004 14:17:29 +0100 [thread overview]
Message-ID: <20040803131729.GL12724@redhat.com> (raw)
In-Reply-To: <20040803124223.GB8574@dominikbrodowski.de>
On Tue, Aug 03, 2004 at 02:42:23PM +0200, Dominik Brodowski wrote:
> On Mon, Aug 02, 2004 at 03:45:14PM -0700, Pallipadi, Venkatesh wrote:
> > This patch was completely missing in 2004-08-02.diff.
> > And it needed some rework too. Here is the updated incremental patch.
>
> Could you send the diff to include/acpi/processor.h as well, please, else
> the build will fail.
Even with that, it still fails the build, with quite a few warnings.
CC arch/i386/kernel/cpu/cpufreq/speedstep-centrino.o
In file included from arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:25:
include/acpi/processor.h:44: error: `ACPI_C_STATE_COUNT' undeclared here (not in a function)
include/acpi/processor.h:60: error: syntax error before "acpi_integer"
include/acpi/processor.h:60: warning: no semicolon at end of struct or union
include/acpi/processor.h:61: warning: type defaults to `int' in declaration of `power'
include/acpi/processor.h:61: warning: data definition has no type or storage class
include/acpi/processor.h:62: error: syntax error before "transition_latency"
include/acpi/processor.h:62: warning: type defaults to `int' in declaration of `transition_latency'
include/acpi/processor.h:62: warning: data definition has no type or storage class
include/acpi/processor.h:63: error: syntax error before "bus_master_latency"
include/acpi/processor.h:63: warning: type defaults to `int' in declaration of `bus_master_latency'
include/acpi/processor.h:63: warning: data definition has no type or storage class
include/acpi/processor.h:64: error: syntax error before "control"
include/acpi/processor.h:64: warning: type defaults to `int' in declaration of `control'
include/acpi/processor.h:64: warning: data definition has no type or storage class
include/acpi/processor.h:65: error: syntax error before "status"
include/acpi/processor.h:65: warning: type defaults to `int' in declaration of `status'
include/acpi/processor.h:65: warning: data definition has no type or storage class
include/acpi/processor.h:125: error: syntax error before "acpi_handle"
include/acpi/processor.h:125: warning: no semicolon at end of struct or union
include/acpi/processor.h:130: error: conflicting types for 'power'
include/acpi/processor.h:61: error: previous declaration of 'power' was here
include/acpi/processor.h:134: error: syntax error before '}' token
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c: In function `centrino_cpu_init_acpi':
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:347: error: `ACPI_PDC_EST_CAPABILITY_SMP' undeclared (first use in this function)
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:347: error: (Each undeclared identifier is reported only once
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:347: error: for each function it appears in.)
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:347: error: `ACPI_PDC_EST_CAPABILITY_MSR' undeclared (first use in this function)
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:370: error: invalid use of undefined type `struct acpi_processor_px'
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:370: error: dereferencing pointer to incomplete type
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:370: error: invalid use of undefined type `struct acpi_processor_px'
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:370: error: dereferencing pointer to incomplete type
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:376: error: invalid use of undefined type `struct acpi_processor_px'
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:376: error: dereferencing pointer to incomplete type
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:382: error: invalid use of undefined type `struct acpi_processor_px'
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:382: error: dereferencing pointer to incomplete type
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:382: error: invalid use of undefined type `struct acpi_processor_px'
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:382: error: dereferencing pointer to incomplete type
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:384: error: invalid use of undefined type `struct acpi_processor_px'
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:384: error: dereferencing pointer to incomplete type
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:397: error: invalid use of undefined type `struct acpi_processor_px'
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:397: error: dereferencing pointer to incomplete type
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:406: error: invalid use of undefined type `struct acpi_processor_px'
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:406: error: dereferencing pointer to incomplete type
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:407: error: invalid use of undefined type `struct acpi_processor_px'
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:407: error: dereferencing pointer to incomplete type
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:423: error: invalid use of undefined type `struct acpi_processor_px'
arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c:423: error: dereferencing pointer to incomplete type
{standard input}: Assembler messages:
{standard input}:341: Error: symbol `power' is already defined
make[1]: *** [arch/i386/kernel/cpu/cpufreq/speedstep-centrino.o] Error 1
make: *** [arch/i386/kernel/cpu/cpufreq/speedstep-centrino.o] Error 2
Dave
next prev parent reply other threads:[~2004-08-03 13:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-02 22:45 post-OLS pending cpufreq patches Pallipadi, Venkatesh
2004-08-03 12:42 ` Dominik Brodowski
2004-08-03 13:17 ` Dave Jones [this message]
2004-08-03 13:30 ` Dominik Brodowski
2004-08-03 13:37 ` Dave Jones
2004-08-03 14:07 ` Dominik Brodowski
2004-08-03 14:19 ` Dave Jones
-- strict thread matches above, loose matches on Subject: below --
2004-08-03 15:06 Pallipadi, Venkatesh
2004-07-27 20:51 Dominik Brodowski
2004-07-28 13:59 ` Dave Jones
2004-07-28 17:25 ` Dominik Brodowski
2004-08-02 19:33 ` Dave Jones
2004-08-02 20:40 ` Dominik Brodowski
2004-08-02 20:42 ` Dominik Brodowski
2004-08-02 20:52 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040803131729.GL12724@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@www.linux.org.uk \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox