From: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
To: davej@redhat.com
Cc: linux@dominikbrodowski.de, cpufreq@www.linux.org.uk
Subject: [PATCH] quieter speedstep-centrino
Date: Thu, 9 Dec 2004 17:27:29 -0800 [thread overview]
Message-ID: <20041209172729.B3337@unix-os.sc.intel.com> (raw)
Patch to remove speedstep-centrino error messages getting printed by default.
Print them only when debug flags are enabled.
The reason for this patch is -
With the multiple drivers model that we have now, any installation will try
different drivers one after the other, until one of them succeeds. So,
failure to add speedstep-centrino alone doesn't mean error, as some other
driver (say acpi.ko) can succeed later and system will still be able to use
speedstep. Printing the error whenever speedstep-centrino fails can confuse
the enduser.
Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
--- linux-2.6.10-rc3/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c.org 2004-12-07 18:48:19.000000000 -0800
+++ linux-2.6.10-rc3/arch/i386/kernel/cpu/cpufreq/speedstep-centrino.c 2004-12-07 18:54:09.000000000 -0800
@@ -239,7 +239,7 @@ static int centrino_cpu_init_table(struc
if (model->cpu_id == NULL) {
/* No match at all */
- printk(KERN_INFO PFX "no support for CPU model \"%s\": "
+ dprintk("no support for CPU model \"%s\": "
"send /proc/cpuinfo to " MAINTAINER "\n",
cpu->x86_model_id);
return -ENOENT;
@@ -247,10 +247,10 @@ static int centrino_cpu_init_table(struc
if (model->op_points == NULL) {
/* Matched a non-match */
- printk(KERN_INFO PFX "no table support for CPU model \"%s\": \n",
+ dprintk("no table support for CPU model \"%s\": \n",
cpu->x86_model_id);
#ifndef CONFIG_X86_SPEEDSTEP_CENTRINO_ACPI
- printk(KERN_INFO PFX "try compiling with CONFIG_X86_SPEEDSTEP_CENTRINO_ACPI enabled\n");
+ dprintk("try compiling with CONFIG_X86_SPEEDSTEP_CENTRINO_ACPI enabled\n");
#endif
return -ENOENT;
}
@@ -352,7 +352,7 @@ static int centrino_cpu_init_acpi(struct
/* register with ACPI core */
if (acpi_processor_register_performance(&p, cpu)) {
- printk(KERN_INFO PFX "obtaining ACPI data failed\n");
+ dprintk("obtaining ACPI data failed\n");
return -EIO;
}
@@ -450,7 +450,7 @@ static int centrino_cpu_init_acpi(struct
kfree(centrino_model[cpu]);
err_unreg:
acpi_processor_unregister_performance(&p, cpu);
- printk(KERN_INFO PFX "invalid ACPI data\n");
+ dprintk("invalid ACPI data\n");
return (result);
}
#else
@@ -481,7 +481,7 @@ static int centrino_cpu_init(struct cpuf
return -ENODEV;
if (!centrino_cpu[policy->cpu]) {
- printk(KERN_INFO PFX "found unsupported CPU with "
+ dprintk("found unsupported CPU with "
"Enhanced SpeedStep: send /proc/cpuinfo to "
MAINTAINER "\n");
return -ENODEV;
next reply other threads:[~2004-12-10 1:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-12-10 1:27 Venkatesh Pallipadi [this message]
2004-12-10 8:15 ` [PATCH] quieter speedstep-centrino Dominik Brodowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20041209172729.B3337@unix-os.sc.intel.com \
--to=venkatesh.pallipadi@intel.com \
--cc=cpufreq@www.linux.org.uk \
--cc=davej@redhat.com \
--cc=linux@dominikbrodowski.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox