cpufreq Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King <rmk@arm.linux.org.uk>
To: Dominik Brodowski <linux@dominikbrodowski.de>,
	Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: cpufreq@zenII.linux.org.uk
Subject: Re: [BUG] cpufreq on SMP with CPUs present but not online
Date: Tue, 18 Jan 2005 19:08:09 +0000	[thread overview]
Message-ID: <20050118190809.C18102@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20050118180630.GB24734@dominikbrodowski.de>; from linux@dominikbrodowski.de on Tue, Jan 18, 2005 at 07:06:30PM +0100

On Tue, Jan 18, 2005 at 07:06:30PM +0100, Dominik Brodowski wrote:
> On Mon, Jan 17, 2005 at 10:38:27PM +0000, Russell King wrote:
> > ... causes the cpufreq driver init method to be called for each CPU.
> > However, this causes something of a dilema on ARM/SMP - if the CPU
> > is not online (because we failed to bring it up via __cpu_up which
> > correctly returned an error), we can't read the current clock rate
> > settings, so we can't initialise policy->{cur,min,max} fields.
> 
> Do I understand you correctly that this CPU will be brought up later?

Possibly - though I'm wondering whether it's really correct to register
the struct cpu for not-currently-online but possible CPUs.  I think this
may make sense, but I'd want to get it confirmed by some SMP folk first.

> > Returning an error from the cpufreq driver init method means that
> > cpufreq completely forgets about this particular CPU, which also
> > isn't desirable.
> > 
> > Ideas?
> 
> Yes. I had tried to integrate cpufreq better with the CPU hotplug core a few
> months ago, but got delayed because of other hotplug-related issues which
> hopefully will be sorted out very soon. Stay tuned.
> 
> 	Dominik
> 
> PS: should we all use cpufreq@zenII.linux.org.uk or @lists.linux.org.uk?

lists.linux.org.uk please.  Unfortunately, when mailservers see the
CNAME for lists.linux.org.uk, they rewrite all addresses to the result
of the CNAME.  Alan - can you change CNAME into:

lists		IN	A	195.92.249.252
		IN	AAAA	2002:c35c:f9fc::1

please?  Thanks.

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 PCMCIA      - http://pcmcia.arm.linux.org.uk/
                 2.6 Serial core

      reply	other threads:[~2005-01-18 19:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-01-17 22:38 [BUG] cpufreq on SMP with CPUs present but not online Russell King
2005-01-18 18:06 ` Dominik Brodowski
2005-01-18 19:08   ` Russell King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050118190809.C18102@flint.arm.linux.org.uk \
    --to=rmk@arm.linux.org.uk \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=cpufreq@zenII.linux.org.uk \
    --cc=linux@dominikbrodowski.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox