From: Jarkko Lavinen <jlavi@iki.fi>
To: Hendrik Muhs <Hendrik.Muhs@web.de>
Cc: Adam Jones <adam@yggdrasl.demon.co.uk>,
Dave Jones <davej@redhat.com>,
cpufreq@zenii.linux.org.uk
Subject: Re: [Patch] powernow-k7-manual was Re: [Patch] small cleanup for powernow-k7.c
Date: Wed, 26 Jan 2005 10:03:40 +0200 [thread overview]
Message-ID: <20050126080340.GA2068@smooth.piipiip.net> (raw)
In-Reply-To: <200501252147.59169.Hendrik.Muhs@web.de>
On Tue, Jan 25, 2005 at 09:47:58PM +0100, Hendrik Muhs wrote:
> To the list: Please complain now!
Hi Hendrik
I tried the patch and it works alright. I have few beauty issues.
There are two consequtive dprintks in powernow_manual_settings() which need
to be unified:
- dprintk(" FID: 0x%x (%d.%dx [%dMHz])\t", fid,
- fid_codes[fid] / 10,
- fid_codes[fid] % 10, speed / 1000);
- dprintk("VID: 0x%x (%d.%03dV)\n", vid,
- mobile_vid_table[vid] / 1000,
+ dprintk(" FID: 0x%x (%d.%dx [%dMHz])\t"
+ "VID: 0x%x (%d.%03dV)\n",
+ fid, fid_codes[fid] / 10,
+ fid_codes[fid] % 10, speed / 1000,
+ vid, mobile_vid_table[vid] / 1000,
+ mobile_vid_table[vid] % 1000);
And there is one unneeded check from my fsb code in powernow_cpu_init(). fsb
is unsigned, myltiplied by 1000 and already checked to be nonzero, so checking
for fsb < 1000 is really not needed.
if (fsb < 1000)
fsb *= 1000;
- if (fsb < 1000 || fsb > 1000000) {
+ if (fsb > 1000000) {
printk(KERN_WARNING PFX "FSB %ukhz out of range\n",
fsb);
return -EINVAL;
> I use it for a HTPC which has a MATX mainboard and a XP-M 2400+. With
> reduced Vcore (BIOS setting), FSB of 100 Mhz (instead of 133 Mhz) and
> this patch I am able to run the CPU without a fan.
I am building a VDR/HTPC box with very similar desires.
Jarkko Lavinen
prev parent reply other threads:[~2005-01-26 8:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-01-20 20:38 [Patch] small cleanup for powernow-k7.c Hendrik Muhs
2005-01-21 1:57 ` Dave Jones
2005-01-25 20:47 ` [Patch] powernow-k7-manual was " Hendrik Muhs
2005-01-26 8:03 ` Jarkko Lavinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050126080340.GA2068@smooth.piipiip.net \
--to=jlavi@iki.fi \
--cc=Hendrik.Muhs@web.de \
--cc=adam@yggdrasl.demon.co.uk \
--cc=cpufreq@zenii.linux.org.uk \
--cc=davej@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox