cpufreq Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: cpufreq@lists.linux.org.uk, Bruno Ducrot <ducrot@poupinou.org>
Subject: Re: OnDemand governor vs. work queue
Date: Wed, 25 May 2005 15:04:34 -0700	[thread overview]
Message-ID: <20050525150433.A9210@unix-os.sc.intel.com> (raw)
In-Reply-To: <1117057707.5076.23.camel@gaston>; from benh@kernel.crashing.org on Thu, May 26, 2005 at 07:48:27AM +1000

On Thu, May 26, 2005 at 07:48:27AM +1000, Benjamin Herrenschmidt wrote:
> 
> > Agreed. For the larger latency transitions, ondemand governor should 
> > use its own thread rather than keventd. Probably, it may make sense to 
> > have separate threads for each CPU as well in that case (as otherwise 
> > this thread will end up being moved around from one CPU to other. I will
> > 
> > look at this in a couple of weeks unless someone beats me to it and 
> > sends the patch before that :).
> 
> A per-CPU thread could be a custom work queue (easy to implement form
> current code) but also a resource waste. I don't think there is that
> much of a problem having that thread moved around.
> 

This is how things work today.
- ondemand (keventd) wakes up on some CPU A.
- Then we loop through all the CPU Is
	- Figure out whether we need to increase the frequency
		- If yes, the underlying governor may (on i386, x86-64 it will)
		  move the thread to CPU I
		- Change the frequency
		- Move the thread back to CPU A.


And each of this affinity calls will wakeup migration thread to do the proper 
affinity and also IPIs for resched. At this moment I am not sure how much 
overhead we have due to this affinity. I need to look closely whether this 
is overhead is significant (Especially on systems with 4 or more CPUs).

-Thanks,
Venki

  reply	other threads:[~2005-05-25 22:04 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-25 21:34 OnDemand governor vs. work queue Pallipadi, Venkatesh
2005-05-25 21:48 ` Benjamin Herrenschmidt
2005-05-25 22:04   ` Venkatesh Pallipadi [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-05-25  3:26 Benjamin Herrenschmidt
2005-05-25  9:59 ` Bruno Ducrot
2005-05-25 21:26   ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050525150433.A9210@unix-os.sc.intel.com \
    --to=venkatesh.pallipadi@intel.com \
    --cc=benh@kernel.crashing.org \
    --cc=cpufreq@lists.linux.org.uk \
    --cc=ducrot@poupinou.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox