From: Dave Jones <davej@redhat.com>
To: "Langsdorf, Mark" <mark.langsdorf@amd.com>
Cc: cpufreq@lists.linux.org.uk
Subject: Re: [PATCH 1/1] Provide support for 6 bit FID codes
Date: Thu, 28 Jul 2005 23:08:28 -0400 [thread overview]
Message-ID: <20050729030828.GA15556@redhat.com> (raw)
In-Reply-To: <84EA05E2CA77634C82730353CBE3A84301CFC1D5@SAUSEXMB1.amd.com>
On Thu, Jun 23, 2005 at 05:39:04PM -0500, Langsdorf, Mark wrote:
> Opteron revision F will support higher frequencies than
> can be encoded in the current driver's 4 bit frequency
> field. This patch updates the driver to support Rev F
> including 6 bit FIDs and processor ID updates.
>
> This should apply cleanly whether or not the dual-core
> bugfix I sent out last week is applied. I'd prefer
> that both get applied, of course.
>
> Signed-off-by: David Keck <david.keck@amd.com>
> Signed-off-by: Mark Langsdorf <mark.langsdorf@amd.com>
>
> -Mark Langsdorf
> AMD, Inc.
arch/i386/kernel/cpu/cpufreq/powernow-k8.c: In function `powernow_k8_acpi_pst_values':
arch/i386/kernel/cpu/cpufreq/powernow-k8.c:698: `EXT_TYPE_SHIFT' undeclared (first use in this function)
arch/i386/kernel/cpu/cpufreq/powernow-k8.c:698: (Each undeclared identifier is reported only once
arch/i386/kernel/cpu/cpufreq/powernow-k8.c:698: for each function it appears in.)
arch/i386/kernel/cpu/cpufreq/powernow-k8.c:698: `EXT_TYPE_MASK' undeclared (first use in this function)
arch/i386/kernel/cpu/cpufreq/powernow-k8.c: In function `powernow_k8_cpu_init_acpi':
arch/i386/kernel/cpu/cpufreq/powernow-k8.c:740: warning: unused variable `vid'
arch/i386/kernel/cpu/cpufreq/powernow-k8.c:739: warning: unused variable `fid'
arch/i386/kernel/cpu/cpufreq/powernow-k8.c:743: warning: unused variable `vid'
arch/i386/kernel/cpu/cpufreq/powernow-k8.c:742: warning: unused variable `fid'
arch/i386/kernel/cpu/cpufreq/powernow-k8.c:746: `fid' undeclared (first use in this function)
arch/i386/kernel/cpu/cpufreq/powernow-k8.c:746: `vid' undeclared (first use in this function)
make[1]: *** [arch/i386/kernel/cpu/cpufreq/powernow-k8.o] Error 1
make: *** [arch/i386/kernel/cpu/cpufreq/powernow-k8.o] Error 2
Looks like there's a chunk of this missing ? Can you send an incremental
fixing this up please ? I'll leave the previous diff in the cpufreq git
tree, and just send the fix along with it when Linus pulls.
Thanks,
Dave
next prev parent reply other threads:[~2005-07-29 3:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-23 22:39 [PATCH 1/1] Provide support for 6 bit FID codes Langsdorf, Mark
2005-07-29 3:08 ` Dave Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-07-29 15:16 Langsdorf, Mark
2005-07-29 16:58 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050729030828.GA15556@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@lists.linux.org.uk \
--cc=mark.langsdorf@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox