From: Dave Jones <davej@redhat.com>
To: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: alexey.y.starikovskiy@intel.com,
cpufreq <cpufreq@www.linux.org.uk>,
Len Brown <lenb@unix-os.sc.intel.com>
Subject: Re: [PATCH 4/4] minor optimizations to ondemand governor
Date: Fri, 30 Jun 2006 01:47:01 -0400 [thread overview]
Message-ID: <20060630054701.GG32729@redhat.com> (raw)
In-Reply-To: <20060630053753.GE32729@redhat.com>
On Fri, Jun 30, 2006 at 01:37:53AM -0400, Dave Jones wrote:
> This gave me rejects against Linus tree for some reason.
> It's wrong anyway, as this file uses mutex's, and I'd rather
> not have to rely on us pulling in mutex.h indirectly through
> some other include file chain.
>
> I fixed it up by hand.
One downside of this patch btw, is that it now increases the
delta between ondemand and conservative a little, which makes
applying the same patch to both a bit more painful.
Care to do a resync sometime ?
Longer term, I'd really like to see conservative & ondemand
sharing more code as a separate helper .o file. They're similar
in so many ways, it seems silly to duplicate so much code.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-06-30 5:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-28 20:52 [PATCH 4/4] minor optimizations to ondemand governor Venkatesh Pallipadi
2006-06-30 5:37 ` Dave Jones
2006-06-30 5:47 ` Dave Jones [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-06-30 7:33 Brown, Len
2006-06-30 19:11 ` Dominik Brodowski
2006-06-30 20:00 ` Rafał Bilski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060630054701.GG32729@redhat.com \
--to=davej@redhat.com \
--cc=alexey.y.starikovskiy@intel.com \
--cc=cpufreq@www.linux.org.uk \
--cc=lenb@unix-os.sc.intel.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox