From: Dave Jones <davej@redhat.com>
To: "Langsdorf, Mark" <mark.langsdorf@amd.com>
Cc: Cpufreq@lists.linux.org.uk, nemesis@icequake.net
Subject: Re: writing a cpufreq driver
Date: Thu, 21 Sep 2006 15:47:14 -0400 [thread overview]
Message-ID: <20060921194714.GH17065@redhat.com> (raw)
In-Reply-To: <1449F58C868D8D4E9C72945771150BDF153669@SAUSEXMB1.amd.com>
On Thu, Sep 21, 2006 at 02:38:22PM -0500, Langsdorf, Mark wrote:
> > > 1. The first time cpufreq changes speed, I get the whole
> > "Losing some
> > > ticks... checking if CPU frequency changed." then
> > eventually "Losing too
> > > many ticks!" and timer switches to PIT. This does not
> > happen when I use
> > > the /dev/toshiba driver to change speeds from userspace.
> > Not sure what
> > > is going on here... SMI handler latency is between 6 and 7 ms.
> >
> > Is loops_per_jiffy being correctly scaled on a speed transition?
> > Hmm, powernow-k7.c seems to be the only driver that's calling
> > recalibrate_cpu_khz()
>
> Do drivers need to be doing that? I would have thought the
> time could would do it after receiving the notification.
Looking at it again..
cpufreq_notify_transition() is calling adjust_jiffies()
which should be doing the same thing, so we should be good to go.
It looks like feasible that recalibrate_cpu_khz() could actually
be killed off.
Dave
next prev parent reply other threads:[~2006-09-21 19:47 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-21 18:48 writing a cpufreq driver Ryan Underwood
2006-09-21 19:31 ` Dave Jones
2006-09-21 19:38 ` Langsdorf, Mark
2006-09-21 19:47 ` Dave Jones [this message]
2006-09-22 15:44 ` Bruno Ducrot
2006-09-22 15:49 ` Dave Jones
2006-09-21 20:08 ` Ryan Underwood
2006-09-21 20:44 ` Dave Jones
2006-09-21 21:03 ` Ryan Underwood
2006-09-21 21:13 ` Dave Jones
2006-09-22 14:13 ` Ryan Underwood
2006-09-22 14:39 ` Ryan Underwood
2006-09-22 15:48 ` Bruno Ducrot
2006-09-22 16:01 ` Ryan Underwood
2006-09-22 15:51 ` Dave Jones
2006-09-22 15:39 ` Bruno Ducrot
2006-09-22 16:00 ` Ryan Underwood
2006-09-22 16:05 ` Bruno Ducrot
2006-09-22 16:11 ` Ryan Underwood
2006-09-23 15:07 ` Bruno Ducrot
2006-09-23 15:21 ` Ryan Underwood
2006-09-23 15:44 ` Bruno Ducrot
2006-09-23 16:03 ` Ryan Underwood
2006-09-23 16:13 ` Bruno Ducrot
2006-09-25 15:39 ` Ryan Underwood
2006-10-02 2:19 ` Dominik Brodowski
2006-09-25 16:44 ` Ryan Underwood
-- strict thread matches above, loose matches on Subject: below --
2006-09-22 16:31 Erik Slagter
2006-09-23 15:31 ` Bruno Ducrot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060921194714.GH17065@redhat.com \
--to=davej@redhat.com \
--cc=Cpufreq@lists.linux.org.uk \
--cc=mark.langsdorf@amd.com \
--cc=nemesis@icequake.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox