From: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
To: Dave Jones <davej@redhat.com>
Cc: alexey.y.starikovskiy@intel.com,
cpufreq <cpufreq@www.linux.org.uk>,
Dominik Brodowski <linux@dominikbrodowski.net>
Subject: Re: [1/5] reorganizes & code cleaning in acpi-cpufreq
Date: Sun, 1 Oct 2006 06:41:26 -0700 [thread overview]
Message-ID: <20061001064126.A16290@unix-os.sc.intel.com> (raw)
In-Reply-To: <20060927024148.GA29163@redhat.com>; from davej@redhat.com on Tue, Sep 26, 2006 at 10:41:48PM -0400
On Tue, Sep 26, 2006 at 10:41:48PM -0400, Dave Jones wrote:
> On Fri, Sep 01, 2006 at 02:07:53PM -0700, Venkatesh Pallipadi wrote:
>
> > Some clean up and redsign of the driver. Mainly making it easier to add
> > support for multiple sub-mechanisms of changing frequency. Currently this
> > driver supports only ACPI SYSTEM_IO address space. With the changes
> > below it is easier to add support for other address spaces like Intel
> > Enhanced Speedstep which uses MSR (ACPI FIXED_FEATURE_HARDWARE) to do the
> > transitions.
>
> This patch-series fell at the first hurdle.
>
> error: patch failed: arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c:91
> error: arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c: patch does not apply
>
This reject was coming from one earlier patch that hasn't gone it yet. The earlier bug fix patch had subject "acpi-cpufreq and software coordination".
> When you repost rediffed patchset, please make the subject of each patch
> in the series a unique description, as this gets used in the shortlog.
>
> As this series failed, your subsequent patches
> acpi-cpufreq: Make cpuinfo_cur_freq work again
> and
> Use IA32_APERF and IA32_MPERF and get freq feedback from hardware
>
> also failed. If you want to fold those into the other changes, or
> just send a complete rediffed 7-series patchset, I'll apply those.
>
OK. Did refresh of all these patches with 2.6.18-git. Will send a 8 patch
patchset now.
Thanks,
Venki
next prev parent reply other threads:[~2006-10-01 13:41 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-01 21:07 [PATCH 1/5] Unify ACPI bits on speedstep-centrino and acpi-cpufreq Venkatesh Pallipadi
2006-09-27 2:40 ` [1/5] reorganizes & code cleaning in acpi-cpufreq Dave Jones
2006-09-27 2:41 ` Dave Jones
2006-10-01 13:41 ` Venkatesh Pallipadi [this message]
2006-10-01 14:05 ` [PATCH 1/8]cpufreq: acpi-cpufreq: software coordination and handle all CPUs in the group Venkatesh Pallipadi
2006-10-01 14:13 ` [PATCH 5/8]cpufreq: acpi-cpufreq: lindent acpi-cpufreq.c Venkatesh Pallipadi
2006-10-01 19:21 ` [1/5] reorganizes & code cleaning in acpi-cpufreq Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061001064126.A16290@unix-os.sc.intel.com \
--to=venkatesh.pallipadi@intel.com \
--cc=alexey.y.starikovskiy@intel.com \
--cc=cpufreq@www.linux.org.uk \
--cc=davej@redhat.com \
--cc=linux@dominikbrodowski.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox