cpufreq Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Jones <davej@redhat.com>
To: "Rafał Bilski" <rafalbilski@interia.pl>
Cc: Dave Jones <davej@codemonkey.org.uk>, cpufreq@lists.linux.org.uk
Subject: Re: [PATCH] Longhaul - Fix hole
Date: Thu, 28 Dec 2006 22:29:18 -0500	[thread overview]
Message-ID: <20061229032918.GA4516@redhat.com> (raw)
In-Reply-To: <458E7AD7.4070306@interia.pl>

On Sun, Dec 24, 2006 at 02:04:23PM +0100, Rafał Bilski wrote:
 > User with Nehemiah B is complain that Longhaul don't 
 > work for him. I don't know much about this issue in 
 > this moment, but looking at source I see possible bug 
 > related to ACPI PM2 register. Patch below.

Can you go into some more detail for the purpose of the changelog?
The above is very vague.

 >  static int __devexit longhaul_cpu_exit(struct cpufreq_policy *policy)
 > @@ -774,8 +779,8 @@ static int __init longhaul_init(void)
 >  
 >  #ifdef CONFIG_SMP
 >  	if (num_online_cpus() > 1) {
 > -		return -ENODEV;
 >  		printk(KERN_ERR PFX "More than 1 CPU detected, longhaul disabled.\n");
 > +		return -ENODEV;
 >  	}
 >  #endif

Gah, I recall fixing this at least twice. Somehow that didn't get pushed out.
I'll commit this bit separately whilst I'm waiting for the description
of the other patch.

Thanks,

		Dave

-- 
http://www.codemonkey.org.uk

  reply	other threads:[~2006-12-29  3:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-24 13:04 [PATCH] Longhaul - Fix hole Rafał Bilski
2006-12-29  3:29 ` Dave Jones [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-12-29 20:32 Rafał Bilski
2006-12-29 20:57 ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061229032918.GA4516@redhat.com \
    --to=davej@redhat.com \
    --cc=cpufreq@lists.linux.org.uk \
    --cc=davej@codemonkey.org.uk \
    --cc=rafalbilski@interia.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox