From: tony@bakeyournoodle.com (Tony Breeds)
To: davej@codemonkey.org.uk
Cc: cpufreq@lists.linux.org.uk
Subject: cpufreq_set_policy removed
Date: Thu, 7 Jun 2007 07:42:43 +1000 [thread overview]
Message-ID: <20070606214243.GX15955@bakeyournoodle.com> (raw)
Hi All,
The git commit 632786ce9ff6206951ee4c84fe5c0d5c1d12f4cc reomved
the "deprecated and buggy" cpufreq_set_policy(). In the linux powerpc
tree we have a driver that's using it.
Offending function:
---
static void cbe_cpufreq_handle_pmi(struct of_device *dev, pmi_message_t pmi_msg)
{
struct cpufreq_policy policy;
u8 cpu;
u8 cbe_pmode_new;
BUG_ON(pmi_msg.type != PMI_TYPE_FREQ_CHANGE);
cpu = cbe_node_to_cpu(pmi_msg.data1);
cbe_pmode_new = pmi_msg.data2;
cpufreq_get_policy(&policy, cpu);
policy.max = min(policy.max, cbe_freqs[cbe_pmode_new].frequency);
policy.min = min(policy.min, policy.max);
pr_debug("cbe_handle_pmi: new policy.min=%d policy.max=%d\n", policy.min, policy.max);
cpufreq_set_policy(&policy);
}
---
What is the correct API to use now?
Yours Tony
linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
next reply other threads:[~2007-06-06 21:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 21:42 Tony Breeds [this message]
2007-06-06 23:01 ` cpufreq_set_policy removed Benjamin Herrenschmidt
2007-06-06 23:13 ` Dave Jones
2007-06-07 1:03 ` Tony Breeds
2007-06-15 17:45 ` Klaus.K Pedersen (Nokia-M/Helsinki)
2007-06-19 12:14 ` Thomas Renninger
2007-06-20 21:20 ` Myron Stowe
2007-06-23 17:32 ` Thomas Renninger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070606214243.GX15955@bakeyournoodle.com \
--to=tony@bakeyournoodle.com \
--cc=cpufreq@lists.linux.org.uk \
--cc=davej@codemonkey.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox