From: Dave Jones <davej@redhat.com>
To: Elias Oltmanns <eo@nebensachen.de>
Cc: cpufreq@lists.linux.org.uk
Subject: Re: [Bug 8581] acpi-cpufreq gets very confused on suspend to ram
Date: Mon, 22 Oct 2007 16:49:24 -0400 [thread overview]
Message-ID: <20071022204924.GB7793@redhat.com> (raw)
In-Reply-To: <87640zr3ka.fsf@denkblock.local>
On Mon, Oct 22, 2007 at 09:50:13AM +0200, Elias Oltmanns wrote:
> > there's some whitespace damage in this patch (spaces instead of tabs).
> > Asides from that though, it looks like the right thing to do.
> > Can you fix that up, and bounce a copy to cpufreq@www.linux.org.uk please?
>
> Well, since this patch was mainly a copy-and-paste job from
> cpufreq_userspace.c, the whitespace damages have been inherited once. In
> fact, I have stumbled upon some more whitespace issues in in the cpufreq
> subsystem and there are also some problems with lacking whitespace
> causing misprinted debugging messages. If you're interested, I can come
> up with a patch fixing all those problems I've accidentally come across.
Yeah, it does seem to be a bit of a disaster. I've just removed some
of the more obvious whitespace damage in cpufreq.git. If you spot
any others after that, patches gratefully accepted.
> Here is the patch fixing cpufreq_conservative.c anyway. It applies to
> 2.6.23.
Applied, thanks Elias.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2007-10-22 20:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <bug-8581-3570@http.bugzilla.kernel.org/>
2007-08-08 17:04 ` [Bug 8581] acpi-cpufreq gets very confused on suspend to ram bugme-daemon
2007-09-23 12:26 ` bugme-daemon
2007-10-06 15:38 ` bugme-daemon
2007-10-08 13:47 ` bugme-daemon
2007-10-12 19:48 ` bugme-daemon
2007-10-21 13:13 ` bugme-daemon
2007-10-22 0:24 ` bugme-daemon
2007-10-22 7:50 ` Elias Oltmanns
2007-10-22 20:49 ` Dave Jones [this message]
2007-06-04 16:45 bugme-daemon
-- strict thread matches above, loose matches on Subject: below --
2007-06-04 12:38 bugme-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071022204924.GB7793@redhat.com \
--to=davej@redhat.com \
--cc=cpufreq@lists.linux.org.uk \
--cc=eo@nebensachen.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox