Re: [PATCH] Eliminate cpufreq_userspace scaling_setspeed deadlock

[Dave Jones <davej@redhat.com>]

On Wed, Nov 07, 2007 at 10:45:35PM -0800, Venki Pallipadi wrote:
 >  
 > 
 > >-----Original Message-----
 > >From: Mattia Dongili [mailto:malattia@linux.it] 
 > >Sent: Wednesday, November 07, 2007 4:57 AM
 > >To: Yu, Luming
 > >Cc: Pallipadi, Venkatesh; Dave Jones; Yu, Fenghua; cpufreq
 > >Subject: Re: [PATCH] Eliminate cpufreq_userspace 
 > >scaling_setspeed deadlock
 > >
 > >On Mon, Nov 05, 2007 at 04:58:18PM +0800, Yu, Luming wrote:
 > >> Based on my current testing results, this patch fixes my problem.
 > >> Please help push it upstream.
 > >
 > >BTW, this will break some userspace apps. I can think of cpufrequtils
 > >and some deamons that use the userspace governor to set frequencies.
 > >
 > 
 > Yes. But, this is the only solution we have for the deadlock right now
 > and I think it should goto upstream as soon as possible, unless we have
 > some better alternative. Userspace breakage is better bargain than a
 > kernel deadlock. Isn't it :-).

I'm torn over this patch.  I don't see a better way to fix this either,
but the potential for breaking userspace is there. I think I'm going to
merge this, and see how things go in -mm for a while.

	Dave

-- 
http://www.codemonkey.org.uk