cpufreq Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: Thomas Renninger <trenn@suse.de>
Cc: Naga Chumbalkar <nagananda.chumbalkar@hp.com>,
	Dave Jones <davej@codemonkey.org.uk>,
	linux-acpi@vger.kernel.org, cpufreq@vger.kernel.org
Subject: Re: [PATCH]: cpufreq: pcc-cpufreq: don't load driver if get_freq fails during init.
Date: Wed, 9 Mar 2011 08:27:23 -0800	[thread overview]
Message-ID: <20110309162723.GA31459@suse.de> (raw)
In-Reply-To: <201103091709.40464.trenn@suse.de>

On Wed, Mar 09, 2011 at 05:09:40PM +0100, Thomas Renninger wrote:
> Good catch.
> 
> On Wednesday, March 09, 2011 03:02:49 PM Naga Chumbalkar wrote:
> > 
> > Return 0 on failure. This will cause the initialization of the driver
> > to fail and prevent the driver from loading if the BIOS cannot handle
> > the PCC interface command to "get frequency". Otherwise, the driver
> > will load and display a very high value like "4294967274" (which is
> > actually -EINVAL) for frequency:
> > 
> > # cat /sys/devices/system/cpu/cpu0/cpufreq/cpuinfo_cur_freq
> > 4294967274
> > 
> > Signed-off-by: Naga Chumbalkar <nagananda.chumbalkar@hp.com>
> Reviewed-by: Thomas Renninger <trenn@suse.de>
> 
> While this is not a regression, it's an easy fix.
> It should make sense to add:
> CC: stable@kernel.org
> ?

Yes you should :)

thanks,

greg k-h

      reply	other threads:[~2011-03-09 16:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-09 14:02 [PATCH]: cpufreq: pcc-cpufreq: don't load driver if get_freq fails during init Naga Chumbalkar
2011-03-09 16:09 ` Thomas Renninger
2011-03-09 16:27   ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110309162723.GA31459@suse.de \
    --to=gregkh@suse.de \
    --cc=cpufreq@vger.kernel.org \
    --cc=davej@codemonkey.org.uk \
    --cc=linux-acpi@vger.kernel.org \
    --cc=nagananda.chumbalkar@hp.com \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox