From: mark gross <markgross@thegnar.org>
To: Antti P Miettinen <amiettinen@nvidia.com>
Cc: davej@redhat.com, cpufreq@vger.kernel.org, pavel@ucw.cz,
rjw@sisk.pl, len.brown@intel.com, linux-pm@vger.kernel.org,
mgross@linux.intel.com
Subject: Re: [PATCH v2 7/8] PM QoS: Add CPU frequency maximum as PM QoS param
Date: Sat, 14 Jan 2012 20:51:43 -0800 [thread overview]
Message-ID: <20120115045143.GD2409@mgross-G62> (raw)
In-Reply-To: <1326459559-5436-8-git-send-email-amiettinen@nvidia.com>
I don't think this belongs in cpufreq.
--mark
On Fri, Jan 13, 2012 at 02:59:18PM +0200, Antti P Miettinen wrote:
> Add maximum CPU frequency as PM QoS parameter.
>
> Signed-off-by: Antti P Miettinen <amiettinen@nvidia.com>
> ---
> include/linux/pm_qos.h | 2 ++
> kernel/power/qos.c | 15 +++++++++++++++
> 2 files changed, 17 insertions(+), 0 deletions(-)
>
> diff --git a/include/linux/pm_qos.h b/include/linux/pm_qos.h
> index 54a0d00..7b8d08b 100644
> --- a/include/linux/pm_qos.h
> +++ b/include/linux/pm_qos.h
> @@ -15,6 +15,7 @@ enum {
> PM_QOS_NETWORK_LATENCY,
> PM_QOS_NETWORK_THROUGHPUT,
> PM_QOS_CPU_FREQ_MIN,
> + PM_QOS_CPU_FREQ_MAX,
>
> /* insert new class ID */
>
> @@ -28,6 +29,7 @@ enum {
> #define PM_QOS_NETWORK_THROUGHPUT_DEFAULT_VALUE 0
> #define PM_QOS_DEV_LAT_DEFAULT_VALUE 0
> #define PM_QOS_CPU_FREQ_MIN_DEFAULT_VALUE 0
> +#define PM_QOS_CPU_FREQ_MAX_DEFAULT_VALUE LONG_MAX
>
> struct pm_qos_request {
> struct plist_node node;
> diff --git a/kernel/power/qos.c b/kernel/power/qos.c
> index 07d761a..04b744b 100644
> --- a/kernel/power/qos.c
> +++ b/kernel/power/qos.c
> @@ -115,12 +115,27 @@ static struct pm_qos_object cpu_freq_min_pm_qos = {
> };
>
>
> +static BLOCKING_NOTIFIER_HEAD(cpu_freq_max_notifier);
> +static struct pm_qos_constraints cpu_freq_max_constraints = {
> + .list = PLIST_HEAD_INIT(cpu_freq_max_constraints.list),
> + .target_value = PM_QOS_CPU_FREQ_MAX_DEFAULT_VALUE,
> + .default_value = PM_QOS_CPU_FREQ_MAX_DEFAULT_VALUE,
> + .type = PM_QOS_MIN,
> + .notifiers = &cpu_freq_max_notifier,
> +};
> +static struct pm_qos_object cpu_freq_max_pm_qos = {
> + .constraints = &cpu_freq_max_constraints,
> + .name = "cpu_freq_max",
> +};
> +
> +
> static struct pm_qos_object *pm_qos_array[] = {
> &null_pm_qos,
> &cpu_dma_pm_qos,
> &network_lat_pm_qos,
> &network_throughput_pm_qos,
> &cpu_freq_min_pm_qos,
> + &cpu_freq_max_pm_qos,
> };
>
> static ssize_t pm_qos_power_write(struct file *filp, const char __user *buf,
> --
> 1.7.4.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-01-15 4:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 12:59 [PATCH v2 0/8] RFC: CPU frequency min/max as PM QoS params Antti P Miettinen
2012-01-13 12:59 ` [PATCH v2 1/8] PM QoS: Simplify PM QoS expansion/merge Antti P Miettinen
2012-01-15 4:37 ` mark gross
2012-01-13 12:59 ` [PATCH v2 2/8] PM QoS: Add CPU frequency minimum as PM QoS param Antti P Miettinen
2012-01-15 4:46 ` mark gross
2012-01-13 12:59 ` [PATCH v2 3/8] cpufreq: Export user_policy min/max Antti P Miettinen
2012-01-13 12:59 ` [PATCH v2 4/8] cpufreq: Preserve sysfs min/max request Antti P Miettinen
2012-01-13 12:59 ` [PATCH v2 5/8] cpufreq: Enforce PM QoS minimum limit Antti P Miettinen
2012-01-15 4:51 ` mark gross
2012-01-13 12:59 ` [PATCH v2 6/8] input: CPU frequency booster Antti P Miettinen
2012-01-13 12:59 ` [PATCH v2 7/8] PM QoS: Add CPU frequency maximum as PM QoS param Antti P Miettinen
2012-01-15 4:51 ` mark gross [this message]
2012-01-13 12:59 ` [PATCH v2 8/8] cpufreq: Enforce PM QoS maximum frequency Antti P Miettinen
2012-01-13 15:24 ` [PATCH v2 0/8] RFC: CPU frequency min/max as PM QoS params mark gross
2012-01-13 16:17 ` Antti P Miettinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120115045143.GD2409@mgross-G62 \
--to=markgross@thegnar.org \
--cc=amiettinen@nvidia.com \
--cc=cpufreq@vger.kernel.org \
--cc=davej@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-pm@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox