Re: [PATCH 6/6 v6] cpufreq, highbank: add support for highbank cpufreq

Shawn Guo
2012-11-28T15:17:44Z

On Wed, Nov 28, 2012 at 10:58:02PM +0800, Shawn Guo wrote:
> On Wed, Nov 28, 2012 at 07:16:12AM -0600, Mark Langsdorf wrote:
> > I'd
> > have to move most of the logic of hb_set_target() into
> > clk_highbank.c:clk_pll_set_rate() and then add extra logic for when
> > cpufreq is not enabled/loaded.
>
> You only need to move hb_voltage_change() into cpu clock's .set_rate()
> hook with no need of checking if cpufreq is enabled or not.
>
Need to also check whether frequency or voltage should be changed first
in .set_rate() though.

Shawn