From: Borislav Petkov <bp@alien8.de>
To: Matthew Garrett <mjg59@srcf.ucam.org>
Cc: "Gopalakrishnan, Aravind" <Aravind.Gopalakrishnan@amd.com>,
"rjw@sisk.pl" <rjw@sisk.pl>, Andre Przywara <andre@andrep.de>,
"cpufreq@vger.kernel.org" <cpufreq@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Andreas <linuxuser330250@gmx.net>
Subject: Re: [PATCH] drivers/cpufreq: Warn user when powernow-k8 tries to fall back to acpi-cpufreq and it is unavailable.
Date: Fri, 18 Jan 2013 18:07:55 +0100 [thread overview]
Message-ID: <20130118170755.GB4062@pd.tnic> (raw)
In-Reply-To: <20130118162347.GA31499@srcf.ucam.org>
On Fri, Jan 18, 2013 at 04:23:47PM +0000, Matthew Garrett wrote:
> On Thu, Jan 17, 2013 at 12:54:37PM +0100, Borislav Petkov wrote:
>
> > So, handoff to acpi-cpufreq still has some issues. When both are
> > built-in, the module_init functions turn into normal initcalls and
> > in that case, they're executed in link order and it can happen that
> > powernowk8_init() runs before acpi_cpufreq_init().
>
> Just flip the link order? It's only the way it is because in the past we
> wanted to try hardware-specific drivers before more generic ones, and I
> don't think that's a concern in this case now.
Yeah, I heard that the acpi-idle and intel-idle drivers do that and also
heard that it was a hack. It doesn't look too ugly IMHO:
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=2671717265ae6e720a9ba5f13fbec3a718983b65
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-01-18 17:07 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-10 1:09 [PATCH] drivers/cpufreq: Warn user when powernow-k8 tries to fall back to acpi-cpufreq and it is unavailable Aravind Gopalakrishnan
2013-01-11 14:49 ` Borislav Petkov
2013-01-11 16:50 ` Borislav Petkov
2013-01-11 17:39 ` Gopalakrishnan, Aravind
2013-01-11 19:03 ` Gopalakrishnan, Aravind
2013-01-17 11:54 ` Borislav Petkov
2013-01-17 11:58 ` [PATCH] powernow-k8: Add a kconfig dependency on acpi-cpufreq Borislav Petkov
2013-01-17 12:53 ` Rafael J. Wysocki
2013-01-17 14:17 ` Borislav Petkov
2013-01-17 22:10 ` Rafael J. Wysocki
2013-01-17 22:12 ` Borislav Petkov
2013-01-18 16:23 ` [PATCH] drivers/cpufreq: Warn user when powernow-k8 tries to fall back to acpi-cpufreq and it is unavailable Matthew Garrett
2013-01-18 17:07 ` Borislav Petkov [this message]
2013-01-18 19:00 ` Borislav Petkov
2013-01-18 19:06 ` Matthew Garrett
2013-01-18 19:36 ` Borislav Petkov
2013-01-18 19:38 ` Matthew Garrett
2013-01-18 19:58 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118170755.GB4062@pd.tnic \
--to=bp@alien8.de \
--cc=Aravind.Gopalakrishnan@amd.com \
--cc=andre@andrep.de \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxuser330250@gmx.net \
--cc=mjg59@srcf.ucam.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox