From mboxrd@z Thu Jan 1 00:00:00 1970 From: Borislav Petkov Subject: Re: [PATCH] drivers/cpufreq: Warn user when powernow-k8 tries to fall back to acpi-cpufreq and it is unavailable. Date: Fri, 18 Jan 2013 20:58:06 +0100 Message-ID: <20130118195806.GA3252@pd.tnic> References: <20130111144940.GB21882@liondog.tnic> <20130111165054.GD10751@liondog.tnic> <4923C2DE085EEB4FAB1D375DD09D0BA6100CF170@sausexdag04.amd.com> <20130117115436.GA3853@pd.tnic> <20130118162347.GA31499@srcf.ucam.org> <20130118170755.GB4062@pd.tnic> <20130118190021.GD4062@pd.tnic> <20130118190659.GB16757@srcf.ucam.org> <20130118193656.GE4062@pd.tnic> <20130118193834.GA17734@srcf.ucam.org> Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1358539091; bh=66PgLW/Yh9Cjw90LbOq2BDonTaKZ15ZBqAfVGEtmWXA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=n03bQQn0QZ+0G57ddj+lLSIRuN9uhMpB2JKfyv iItZUUba1Er7us4wJVrSvhPh4eCIgJ1JDR2eCNFrEvCz4i+kr/5aIJdzZ9FP57lvhOt W2rZ/i7RUGMr6K7C5bZla3LPICx+7qcx81jQ0rMDDYtNngDHNaj1k7Ogl5I5lVr/YM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alien8.de; s=alien8; t=1358539091; bh=66PgLW/Yh9Cjw90LbOq2BDonTaKZ15ZBqAfVGEtmWXA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:In-Reply-To; b=n03bQQn0QZ+0G57ddj+lLSIRuN9uhMpB2JKfyv iItZUUba1Er7us4wJVrSvhPh4eCIgJ1JDR2eCNFrEvCz4i+kr/5aIJdzZ9FP57lvhOt W2rZ/i7RUGMr6K7C5bZla3LPICx+7qcx81jQ0rMDDYtNngDHNaj1k7Ogl5I5lVr/YM= Content-Disposition: inline In-Reply-To: <20130118193834.GA17734@srcf.ucam.org> Sender: cpufreq-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Matthew Garrett Cc: "Gopalakrishnan, Aravind" , "rjw@sisk.pl" , Andre Przywara , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Andreas On Fri, Jan 18, 2013 at 07:38:34PM +0000, Matthew Garrett wrote: > On Fri, Jan 18, 2013 at 08:36:56PM +0100, Borislav Petkov wrote: > > > Ok, how much can we rely on ACPI to have this ACPI_ADR_SPACE_SYSTEM_IO > > properly set on K8? Because the thing is, we want to use acpi-cpufreq on > > F10h onwards and leave powernow-k8 to K8s. > > SYSTEM_IO only supports single processors and was superceded in ACPI > 2.0. Are there any single-core F10h? Hmm, maybe some downcored creations, who knows? But actually, that doesn't matter: we want to exit early from acpi-cpufreq loading on K8 only so the check should simply be: if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD && boot_cpu_data.x86 == 0xf) { pr_debug(...) ... } Yeah, I think that should work. I'll add your patch to the others and make a patchset to give it a run. If it looks good, we'll queue it for 3.9 so that it can see more testing. Thanks. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --