Re: [PATCH] powernow-k8: Add a kconfig dependency on acpi-cpufreq

Rafael J. Wysocki
2013-01-17T12:53:55Z

On Thursday, January 17, 2013 12:58:44 PM Borislav Petkov wrote:
> From: Borislav Petkov <bp@suse.de>
> Date: Thu, 17 Jan 2013 12:44:20 +0100
> Subject: [PATCH] powernow-k8: Add a kconfig dependency on acpi-cpufreq
>
> Andreas reports in https://bugzilla.kernel.org/show_bug.cgi?id=51741
> that with his Gentoo config, acpi-cpufreq wasn't enabled and powernow-k8
> couldn't handoff properly to acpi-cpufreq leading to running without
> P-state support (i.e., cores are constantly in P0).
>
> To alleaviate that, we need to make powernow-k8 depend on acpi-cpufreq
> so that acpi-cpufreq is always present.

OK

Do we need that in -stable?

Rafael

> Cc: Andre Przywara <andre@andrep.de>
> Reported-by: Andreas <linuxuser330250@gmx.net>
> Signed-off-by: Borislav Petkov <bp@suse.de>
> ---
> drivers/cpufreq/Kconfig.x86 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/Kconfig.x86 b/drivers/cpufreq/Kconfig.x86
> index 934854ae5eb4..7227cd734042 100644
> --- a/drivers/cpufreq/Kconfig.x86
> +++ b/drivers/cpufreq/Kconfig.x86
> @@ -106,7 +106,7 @@ config X86_POWERNOW_K7_ACPI
> config X86_POWERNOW_K8
> tristate "AMD Opteron/Athlon64 PowerNow!"
> select CPU_FREQ_TABLE
> - depends on ACPI && ACPI_PROCESSOR
> + depends on ACPI && ACPI_PROCESSOR && X86_ACPI_CPUFREQ
> help
> This adds the CPUFreq driver for K8/early Opteron/Athlon64 processors.
> Support for K10 and newer processors is now in acpi-cpufreq.
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.