From: Andrew Lunn <andrew@lunn.ch>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
rjw@sisk.pl, jacmet@sunsite.dk,
linux ARM <linux-arm-kernel@lists.infradead.org>,
cpufreq@vger.kernel.org, viresh.kumar@linaro.org
Subject: Re: [PATCH v3 1/3] cpufreq: kirkwood: Add a cpufreq driver for Marvell Kirkwood SoCs
Date: Sun, 27 Jan 2013 18:23:58 +0100 [thread overview]
Message-ID: <20130127172358.GM29973@lunn.ch> (raw)
In-Reply-To: <20130127171111.GG23505@n2100.arm.linux.org.uk>
> > + clkspec.np = np;
> > + clkspec.args_count = 1;
> > + clkspec.args[0] = 1;
> > +
> > + priv.cpu_clk = of_clk_get_from_provider(&clkspec);
>
> Oh, yet another way to get clocks...
Yep. I didn't like it, but could not find a better way. It has been
argued that cpufreq drivers should not have nodes in DT. So the normal
of_clk_get() does not work. Since the clocks themselves are
instantiated from DT, there are no clkdev alias, so plain clk_get()
also does not work.
Do you know of a better way to do this?
Thanks
Andrew
next prev parent reply other threads:[~2013-01-27 17:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-27 10:07 [PATCH v3 0/3] Kirkwoode cpufreq driver Andrew Lunn
2013-01-27 10:07 ` [PATCH v3 1/3] cpufreq: kirkwood: Add a cpufreq driver for Marvell Kirkwood SoCs Andrew Lunn
2013-01-27 14:49 ` Viresh Kumar
2013-01-27 15:42 ` Andrew Lunn
2013-01-27 16:03 ` Viresh Kumar
2013-01-27 16:25 ` Andrew Lunn
2013-01-27 16:45 ` Viresh Kumar
2013-01-27 17:17 ` Andrew Lunn
2013-01-28 3:19 ` Viresh Kumar
2013-01-27 17:11 ` Russell King - ARM Linux
2013-01-27 17:23 ` Andrew Lunn [this message]
2013-01-28 6:41 ` Shawn Guo
2013-01-27 18:20 ` Andrew Lunn
2013-01-27 10:07 ` [PATCH v3 2/3] arm: kirkwood: Instantiate cpufreq driver Andrew Lunn
2013-05-26 17:59 ` Jason Cooper
2013-01-27 10:07 ` [PATCH v3 3/3] arm: kirkwood: Enable cpufreq and ondemand on kirkwood_defconfig Andrew Lunn
2013-05-26 18:02 ` Jason Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130127172358.GM29973@lunn.ch \
--to=andrew@lunn.ch \
--cc=cpufreq@vger.kernel.org \
--cc=jacmet@sunsite.dk \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=rjw@sisk.pl \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox