From mboxrd@z Thu Jan 1 00:00:00 1970 From: Fabio Baltieri Subject: Re: [PATCH 2/5] cpufreq: star/stop cpufreq timers on cpu hotplug Date: Wed, 30 Jan 2013 11:44:32 +0100 Message-ID: <20130130104432.GB32315@balto.lan> References: <1356620142-8680-1-git-send-email-fabio.baltieri@linaro.org> <1356620142-8680-3-git-send-email-fabio.baltieri@linaro.org> Mime-Version: 1.0 Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Viresh Kumar , "Rafael J. Wysocki" Cc: cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, Linus Walleij , linux-kernel@vger.kernel.org, josephl@nvidia.com, swarren@wwwdotorg.org, linaro-dev@lists.linaro.org, Nicolas Pitre , mathieu.poirier@linaro.org Hi Viresh, On Wed, Jan 30, 2013 at 10:22:37AM +0530, Viresh Kumar wrote: > Hi Fabio, > > Sorry for waking up very late :) > > The reason why i am starting this thread again is due to problem > reported by Joseph, > with latest linux-next/master branch (which contains few big patches > from me :) ): > > Reboot is giving following to him: > > * Will now halt > [ 193.756068] Disabling non-boot CPUs... > [ 193.760088] BUG: scheduling while atomic: halt/780/0x00000002 > [ 193.765845] Modules linked in: brcmfmac brcmutil > [ 193.770613] [] (unwind_backtrace+0x0/0xf8) from [] > (__schedule_bug+0x44/0x5c) > [ 193.779548] [] (__schedule_bug+0x44/0x5c) from [] > (__schedule+0x688/0x6ec) > [ 193.788206] [] (__schedule+0x688/0x6ec) from [] > (schedule_preempt_disabled+0x24/0x34) > [ 193.797811] [] (schedule_preempt_disabled+0x24/0x34) from > [] (__mutex_lock_slowpath+0x170/0x34c) > [ 193.808367] [] (__mutex_lock_slowpath+0x170/0x34c) from > [] (mutex_lock+0xc/0x24) > [ 193.817554] [] (mutex_lock+0xc/0x24) from [] > (unregister_cpu_notifier+0xc/0x24) > [ 193.826640] [] (unregister_cpu_notifier+0xc/0x24) from > [] (cpufreq_governor_dbs+0x118/0x614) > [ 193.836866] [] (cpufreq_governor_dbs+0x118/0x614) from > [] (__cpufreq_governor+0x58/0xc0) > [ 193.846737] [] (__cpufreq_governor+0x58/0xc0) from > [] (__cpufreq_remove_dev.clone.7+0x58/0x320) > [ 193.857207] [] (__cpufreq_remove_dev.clone.7+0x58/0x320) > from [] (cpufreq_cpu_callback+0x8c/0x9c) > [ 193.867850] [] (cpufreq_cpu_callback+0x8c/0x9c) from > [] (notifier_call_chain+0x44/0x84) > [ 193.877623] [] (notifier_call_chain+0x44/0x84) from > [] (__cpu_notify+0x2c/0x48) > [ 193.886704] [] (__cpu_notify+0x2c/0x48) from [] > (_cpu_down+0xb0/0x23c) > [ 193.895004] [] (_cpu_down+0xb0/0x23c) from [] > (disable_nonboot_cpus+0x68/0x104) > [ 193.904089] [] (disable_nonboot_cpus+0x68/0x104) from > [] (kernel_power_off+0x24/0x48) > [ 193.913688] [] (kernel_power_off+0x24/0x48) from > [] (sys_reboot+0x104/0x1e0) > [ 193.922517] [] (sys_reboot+0x104/0x1e0) from [] > (ret_fast_syscall+0x0/0x30) > > > And the crash log show this patch of yours somewhere :) It looks like the two patches clashed togher quite badly... :-) On Wed, Jan 30, 2013 at 10:22:37AM +0530, Viresh Kumar wrote: [...] > First question: Is this patch still required? Because following patch > from me is > sending a STOP/START to governors on cpu hot-[un]plug ? > > commit dbcb63407c095af73f3464767e00902cdee55e8b > Author: Viresh Kumar > Date: Sat Jan 12 05:14:39 2013 +0000 > > cpufreq: Notify governors when cpus are hot-[un]plugged > > For me, the answer is NO. I confirm that your patch handles correctly the problem solved by this one so I agree on dropping mine. Rafael, this is screwing up a bit on bisection for cpu hotplug problems so I'm sending a v7 with the cleanup on first patch and this one dropped if you are ok with rebasing your pm-cpufreq-next. Let me know if you prefer me to just send a revert + cleanup patch instead. Thanks, Fabio -- Fabio Baltieri