From mboxrd@z Thu Jan 1 00:00:00 1970 From: Artem Savkov Subject: Re: [PATCH 0/4] CPUFreq Fixes for 3.9 Date: Thu, 7 Feb 2013 23:39:44 +0400 Message-ID: <20130207193944.GA4016@thinkpad.lan> References: Mime-Version: 1.0 Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:date:from:to:cc:subject:message-id:references :mime-version:content-type:content-disposition:in-reply-to :user-agent; bh=0rTt6Pa4vDI2x3qerrZVercXnUwsMIrBmBWoEv6jthI=; b=e0DBnn0uVgd84dRfu8d9xI/YhmXs27DYX65lLbjV4nZvzLS59eNlxVn/BKW9X7oTE8 M3fUZU277ES27ByK6rixPzDS76pKP/GSrgZkIqsXGsZSyH9BPxHi7tejiENZGUZAth+l dB4I995AY0ppJLETQCLmoLtd2mBiEtWlbmGreOLz5VepfPXunaFJ3LpqeRnkdDgNtgyg SRmajnobI0LFCnspTTr4P29rzqpkri5WQu3WyKH7CtQr4tZXaBhChqfuRBECWjrTLgdb ZMAeoqTQgJRXfK5D3JA1AkLqC9GOq1kfFU80ty4sk2UvVVqNoHQpvJdDRGzsHeVG5iNY QKXw== Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Viresh Kumar Cc: rjw@sisk.pl, valdis.kletnieks@vt.edu, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com On Thu, Feb 07, 2013 at 03:57:42PM +0530, Viresh Kumar wrote: > Hi Rafael, > > This is another unplanned patchset for all the platforms that i broke. :) > > Okay, there are two important fixes (1 & 4) and two general cleanups (2 & 3). I > hope most of the issues would be resolved by these and we would be able to push > clean cpufreq core into 3.9. > > I have pushed them in my for-rafael branch at: > > http://git.linaro.org/gitweb?p=people/vireshk/linux.git;a=shortlog;h=refs/heads/for-rafael > > @Artem & Valdis: Please test them and reply with your Tested-by's (in case they > work :) ). > > Viresh Kumar (4): > cpufreq: governors: Fix WARN_ON() for multi-policy platforms > cpufreq: Remove unused HOTPLUG_CPU code > cpufreq: Create a macro for unlock_policy_rwsem{read,write} > cpufreq: Fix locking issues > > drivers/cpufreq/cpufreq.c | 126 ++++++++++++++++++------------------- > drivers/cpufreq/cpufreq_governor.c | 32 ++++++---- > 2 files changed, 79 insertions(+), 79 deletions(-) Tested out linux-pm.git/linux-next with this patches pulled. It seems that my systemd-sleep issue is fixed, however there is a new 'sleeping in invalid context' bug during boot: [ 12.736484] BUG: sleeping function called from invalid context at mm/slub.c:925 [ 12.739727] in_atomic(): 1, irqs_disabled(): 1, pid: 1799, name: systemd-modules [ 12.742961] 2 locks held by systemd-modules/1799: [ 12.746153] #0: (subsys mutex#3){......}, at: [] subsys_interface_register+0x36/0xb0 [ 12.749499] #1: (cpufreq_driver_lock){......}, at: [] cpufreq_add_dev+0x22b/0x3d0 [ 12.752865] Pid: 1799, comm: systemd-modules Not tainted 3.8.0-rc6+ #1 [ 12.756175] Call Trace: [ 12.759538] [] __might_sleep+0xe0/0x100 [ 12.762156] [] kmem_cache_alloc_trace+0xb1/0x150 [ 12.765432] [] ? acpi_cpufreq_cpu_init+0x73/0x5c0 [acpi_cpufreq] [ 12.768780] [] acpi_cpufreq_cpu_init+0x73/0x5c0 [acpi_cpufreq] [ 12.772161] [] ? cpufreq_add_dev+0x22b/0x3d0 [ 12.775549] [] ? _raw_spin_lock_irqsave+0x77/0x90 [ 12.778932] [] ? cpufreq_add_dev+0x22b/0x3d0 [ 12.782307] [] cpufreq_add_dev+0x238/0x3d0 [ 12.785652] [] subsys_interface_register+0x75/0xb0 [ 12.788989] [] ? do_drv_write+0x80/0x80 [acpi_cpufreq] [ 12.792325] [] cpufreq_register_driver+0x7b/0x150 [ 12.795657] [] ? 0xf8074fff [ 12.798971] [] acpi_cpufreq_init+0xae/0x1b3 [acpi_cpufreq] [ 12.802346] [] do_one_initcall+0x112/0x160 [ 12.805723] [] ? __blocking_notifier_call_chain+0x4a/0x80 [ 12.809123] [] load_module+0xd7e/0x1460 [ 12.812515] [] ? error_code+0x5a/0x60 [ 12.815891] [] sys_init_module+0x78/0xb0 [ 12.819249] [] sysenter_do_call+0x12/0x2d [ 12.822924] ------------[ cut here ]------------ [ 12.826275] WARNING: at kernel/smp.c:327 smp_call_function_single+0x104/0x130() [ 12.829668] Hardware name: 0578A21 [ 12.833020] Modules linked in: acpi_cpufreq(+) mperf thinkpad_acpi [ 12.836456] Pid: 1799, comm: systemd-modules Not tainted 3.8.0-rc6+ #1 [ 12.839891] Call Trace: [ 12.843268] [] warn_slowpath_common+0x72/0xa0 [ 12.846617] [] ? smp_call_function_single+0x104/0x130 [ 12.849921] [] ? smp_call_function_single+0x104/0x130 [ 12.853149] [] ? acpi_cpufreq_target+0x280/0x280 [acpi_cpufreq] [ 12.856361] [] warn_slowpath_null+0x22/0x30 [ 12.859518] [] smp_call_function_single+0x104/0x130 [ 12.862691] [] smp_call_function_any+0x44/0xb0 [ 12.865788] [] ? acpi_cpufreq_target+0x280/0x280 [acpi_cpufreq] [ 12.868893] [] get_cur_val+0x7e/0x100 [acpi_cpufreq] [ 12.871957] [] get_cur_freq_on_cpu+0x4b/0x70 [acpi_cpufreq] [ 12.874987] [] acpi_cpufreq_cpu_init+0x3d8/0x5c0 [acpi_cpufreq] [ 12.877998] [] ? cpufreq_add_dev+0x22b/0x3d0 [ 12.880982] [] cpufreq_add_dev+0x238/0x3d0 [ 12.883931] [] subsys_interface_register+0x75/0xb0 [ 12.886840] [] ? do_drv_write+0x80/0x80 [acpi_cpufreq] [ 12.889717] [] cpufreq_register_driver+0x7b/0x150 [ 12.892550] [] ? 0xf8074fff [ 12.895339] [] acpi_cpufreq_init+0xae/0x1b3 [acpi_cpufreq] [ 12.898169] [] do_one_initcall+0x112/0x160 [ 12.900988] [] ? __blocking_notifier_call_chain+0x4a/0x80 [ 12.903820] [] load_module+0xd7e/0x1460 [ 12.906631] [] ? error_code+0x5a/0x60 [ 12.909418] [] sys_init_module+0x78/0xb0 [ 12.912193] [] sysenter_do_call+0x12/0x2d [ 12.914956] ---[ end trace e15032846f0195a0 ]--- -- Kind regards, Artem