From: bugzilla-daemon@bugzilla.kernel.org
To: cpufreq@vger.kernel.org
Subject: [Bug 56691] Using Intel Pstates driver causes panics during high loads
Date: Tue, 16 Apr 2013 17:45:39 +0000 (UTC) [thread overview]
Message-ID: <20130416174539.E03F811FA4E@bugzilla.kernel.org> (raw)
In-Reply-To: <bug-56691-12968@https.bugzilla.kernel.org/>
https://bugzilla.kernel.org/show_bug.cgi?id=56691
Dirk Brandewie <dirk.brandewie@gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dirk.brandewie@gmail.com
--- Comment #2 from Dirk Brandewie <dirk.brandewie@gmail.com> 2013-04-16 17:45:39 ---
This is the same bug as reported by Redhat
https://bugzilla.redhat.com/show_bug.cgi?id=952244
I took a long time to reproduce and catch it in the act and get debug info :-(
The fix missed rc6 by a few hours but is in rc7.
--Dirk
Author: Dirk Brandewie <dirk.brandewie@gmail.com> 2013-04-04 10:35:35
Committer: Rafael J. Wysocki <rafael.j.wysocki@intel.com> 2013-04-08 13:09:23
Parent: 05e99c8cf9d4e53ef6e016815db40a89a6156529 (intel-pstate: Use #defines
instead of hard-coded values.)
Branches: master, pstate, pstate.stgit, remotes/linux-pm/bleeding-edge,
remotes/linux-pm/fixes, remotes/linux-pm/linux-next, remotes/next/akpm,
remotes/next/akpm-base, remotes/next/master, remotes/next/stable,
remotes/origin/master, test_next
Follows: v3.9-rc6
Precedes: pm-3.9-rc7
cpufreq / intel_pstate: Set timer timeout correctly
The current calculation of the delay time is wrong and a cut and
paste error from a previous experimental driver. This can result in
the timeout being set to jiffies + 1 which setup the driver to race
with itself if the APIC timer interrupt happens at just the right
time.
References: https://bugzilla.redhat.com/show_bug.cgi?id=920289
Reported-by: Adam Williamson <awilliam@redhat.com>
Reported-and-tested-by: Parag Warudkar <parag.lkml@gmail.com>
Signed-off-by: Dirk Brandewie <dirk.j.brandewie@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
------------------------ drivers/cpufreq/intel_pstate.c
------------------------
index ad72922..6133ef5 100644
@@ -502,7 +502,6 @@ static inline void intel_pstate_set_sample_time(struct
cpudata *cpu)
sample_time = cpu->pstate_policy->sample_rate_ms;
delay = msecs_to_jiffies(sample_time);
- delay -= jiffies % delay;
mod_timer_pinned(&cpu->timer, jiffies + delay);
}
--
Configure bugmail: https://bugzilla.kernel.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
next prev parent reply other threads:[~2013-04-16 17:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-16 17:31 [Bug 56691] New: Using Intel Pstates driver causes panics during high loads bugzilla-daemon
2013-04-16 17:34 ` [Bug 56691] " bugzilla-daemon
2013-04-16 17:45 ` bugzilla-daemon [this message]
2013-04-16 18:03 ` bugzilla-daemon
2013-04-17 2:04 ` bugzilla-daemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130416174539.E03F811FA4E@bugzilla.kernel.org \
--to=bugzilla-daemon@bugzilla.kernel.org \
--cc=cpufreq@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox