public inbox for cpufreq@vger.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
Cc: Sylwester Nawrocki <s.nawrocki@samsung.com>,
	linux-samsung-soc <linux-samsung-soc@vger.kernel.org>,
	cpufreq@vger.kernel.org, Tomasz Figa <t.figa@samsung.com>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Thomas Abraham <thomas.abraham@linaro.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	'linux-arm-kernel' <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] cpufreq: exynos: allow disabling cpufreq drivers
Date: Fri, 19 Apr 2013 22:43:30 +0200	[thread overview]
Message-ID: <201304192243.30430.arnd@arndb.de> (raw)
In-Reply-To: <5171AB10.5070702@gmail.com>

On Friday 19 April 2013, Sylwester Nawrocki wrote:
> > It could also be working by chance on EXYNOS4, since the register
> > definitions were not actually removed from the regs-clk.h header
> > for those.
> 
> That's most likely what happened.

Ok. I think I see the bigger picture now. The EXYNOS5 cpufreq driver was
actually just merged now, so I assume that by the time Thomas did the clock
changes, the register definitions for EXYNOS5 were actually unused and he
subsequently removed them from the kernel.

Since the driver now depends on them, I think the only way forward for 3.10
is to revert the change that removed the definitions and put them back in
place.

We really should use the clock API from all the exynos cpufreq drivers, but it's
too late for that change now in 3.10 and we will have to do it for 3.11 then.

This are not looking so good for exynos multiplatform support in 3.10 now, but
if we get it in, that will mean we have to disable cpufreq when building
multiplatform, but it can remain for the classic single-platform configurations.

	Arnd

  reply	other threads:[~2013-04-19 20:43 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-19 13:54 [PATCH] cpufreq: exynos: allow disabling cpufreq drivers Arnd Bergmann
2013-04-19 14:33 ` Arnd Bergmann
2013-04-19 16:51 ` Sylwester Nawrocki
2013-04-19 18:59   ` Arnd Bergmann
2013-04-19 20:37     ` Sylwester Nawrocki
2013-04-19 20:43       ` Arnd Bergmann [this message]
2013-04-19 21:12         ` Sylwester Nawrocki
2013-04-19 21:10       ` [PATCH] ARM: exynos: restore mach/regs-clock.h for exynos5 Arnd Bergmann
2013-04-19 21:17         ` Olof Johansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201304192243.30430.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=cpufreq@vger.kernel.org \
    --cc=kgene.kim@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=s.nawrocki@samsung.com \
    --cc=sylvester.nawrocki@gmail.com \
    --cc=t.figa@samsung.com \
    --cc=thomas.abraham@linaro.org \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox