Re: [PATCH v4 2/7] cpufreq: Add boost frequency support in core

Lukasz Majewski
2013-06-28T07:31:05Z

On Fri, 28 Jun 2013 12:21:21 +0530, Viresh Kumar wrote:

> On 28 June 2013 12:19, Lukasz Majewski <l.majewski@samsung.com> wrote:
> > No, I will use:
> >
> > if (boost_enabled != state) {
> > write_lock_irqsave(&cpufreq_driver_lock, flags);
> > boost_enabled = state;
> >
> > ret = cpufreq_driver->enable_boost(state);
> > ^^^^^^^^^^^^^^^^^^^^ only one callback call
> > if (ret)
> > boost_enabled = 0;
> >
> > write_unlock_irqrestore(&cpufreq_driver_lock, flags);
> >
> > if (ret)
> > pr_err("%s: BOOST cannot enable (%d)\n",
> > __func__, ret);
> > }
> >
> > and @ cpufreq_register_driver() I will add following line:
> >
> > if (!cpufreq_driver->enable_boost)
> > cpufreq_driver->enable_boost = &cpufreq_boost_enable_sw;
> >
> > When cpufreq driver doesn't define callback for enable_boost it
> > will be filled with default SW cpufreq_boost_enable_sw callback.
>
> That's some smart code. Good. :)

OK

--
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group