Re: [PATCH v6 5/8] cpufreq:boost:Kconfig: Provide support for software managed BOOST

Lukasz Majewski
2013-08-12T10:50:12Z

On Mon, 12 Aug 2013 15:58:12 +0530 Viresh Kumar viresh.kumar@linaro.org
wrote,
> On 12 August 2013 15:56, Lukasz Majewski <l.majewski@samsung.com>
> wrote:
> > 1. at ./drivers/cpufreq/Kconfig:
> >
> > +config CPU_FREQ_BOOST_SW
> > + bool
> > + depends on THERMAL
> >
> > 2. at ./drivers/cpufreq/Kconfig.arm:
> >
> > +config ARM_EXYNOS_CPU_FREQ_BOOST_SW
> > + bool "EXYNOS Frequency Overclocking - Software"
> > + depends on ARM_EXYNOS_CPUFREQ
> > + select CPU_FREQ_BOOST_SW
> > + select EXYNOS_THERMAL
> > + default n
^^^^^^^^^^^^^^^^ I will also remove this line.

> > + help
> > + This driver supports software managed overclocking
> > (BOOST).
> > + It allows usage of special frequencies for Samsung Exynos
> > + processors if thermal conditions are appropriate.
> > +
> > + It reguires, for safe operation, thermal framework with
> > properly
> > + defined trip points.
> > +
> > + If in doubt, say N.
> > +
> >
> > Shall I split this patch to two (1. and 2.) or leave it as a single
> > one?
>
> Looks fine.. Keep it in a single patch.

Ok.

--
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group