From: Gautham R Shenoy <ego@linux.vnet.ibm.com>
To: "Srivatsa S. Bhat" <srivatsa.bhat@linux.vnet.ibm.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Viresh Kumar <viresh.kumar@linaro.org>,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>,
"ego@linux.vnet.ibm.com" <ego@linux.vnet.ibm.com>,
Preeti U Murthy <preeti@linux.vnet.ibm.com>
Subject: Re: [PATCH] cpufreq: powernv: make local function static
Date: Mon, 12 May 2014 11:24:06 +0530 [thread overview]
Message-ID: <20140512055406.GA3804@in.ibm.com> (raw)
In-Reply-To: <536FC254.2000702@linux.vnet.ibm.com>
On Mon, May 12, 2014 at 12:02:52AM +0530, Srivatsa S. Bhat wrote:
> On 05/11/2014 01:21 PM, Brian Norris wrote:
> > powernv_cpufreq_get() is only referenced in this file.
> >
> > Signed-off-by: Brian Norris <computersforpeace@gmail.com>
> > Cc: Viresh Kumar <viresh.kumar@linaro.org>
> > Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Cc: cpufreq@vger.kernel.org
> > Cc: linux-pm@vger.kernel.org
>
> Reviewed-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Thanks for this fix Brian.
Reviewed-by: Gautham R. Shenoy <ego@linux.vnet.ibm.com>
--
Thanks and Regards
gautham.
>
> Regards,
> Srivatsa S. Bhat
>
> > ---
> > drivers/cpufreq/powernv-cpufreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/powernv-cpufreq.c b/drivers/cpufreq/powernv-cpufreq.c
> > index af4968813e76..bb1d08dc8cc8 100644
> > --- a/drivers/cpufreq/powernv-cpufreq.c
> > +++ b/drivers/cpufreq/powernv-cpufreq.c
> > @@ -235,7 +235,7 @@ static void powernv_read_cpu_freq(void *arg)
> > * firmware for CPU 'cpu'. This value is reported through the sysfs
> > * file cpuinfo_cur_freq.
> > */
> > -unsigned int powernv_cpufreq_get(unsigned int cpu)
> > +static unsigned int powernv_cpufreq_get(unsigned int cpu)
> > {
> > struct powernv_smp_call_data freq_data;
> >
next prev parent reply other threads:[~2014-05-12 5:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 7:51 [PATCH] cpufreq: powernv: make local function static Brian Norris
2014-05-11 18:32 ` Srivatsa S. Bhat
2014-05-12 5:54 ` Gautham R Shenoy [this message]
2014-05-19 23:21 ` Rafael J. Wysocki
2014-05-12 4:24 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512055406.GA3804@in.ibm.com \
--to=ego@linux.vnet.ibm.com \
--cc=computersforpeace@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=preeti@linux.vnet.ibm.com \
--cc=rafael.j.wysocki@intel.com \
--cc=srivatsa.bhat@linux.vnet.ibm.com \
--cc=svaidy@linux.vnet.ibm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).