From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Mark Brown <broonie@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>,
cpufreq@vger.kernel.org, linaro-kernel@lists.linaro.org,
Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] cpufreq: cpufreq-cpu0: Use devm_regulator_get_optional()
Date: Tue, 13 Aug 2013 15:07:07 +0200 [thread overview]
Message-ID: <3483292.v6fTkTpAqi@vostro.rjw.lan> (raw)
In-Reply-To: <1376071683-19013-1-git-send-email-broonie@kernel.org>
On Friday, August 09, 2013 07:08:03 PM Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Since the cpufreq-cpu0 driver is capable of coping without a software
> controllable regulator and would be confused by a dummy one it should
> use devm_regulator_get_optional() to ensure no dummy is provided.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
> ---
>
> devm_regulator_get_optional() is a new API in my tree for -next, is it
> OK to merge this patch via that branch?
Sure, please go ahead.
Thanks,
Rafael
> drivers/cpufreq/cpufreq-cpu0.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq-cpu0.c b/drivers/cpufreq/cpufreq-cpu0.c
> index 09cd3a7..b946ac7 100644
> --- a/drivers/cpufreq/cpufreq-cpu0.c
> +++ b/drivers/cpufreq/cpufreq-cpu0.c
> @@ -197,7 +197,7 @@ static int cpu0_cpufreq_probe(struct platform_device *pdev)
> cpu_dev = &pdev->dev;
> cpu_dev->of_node = np;
>
> - cpu_reg = devm_regulator_get(cpu_dev, "cpu0");
> + cpu_reg = devm_regulator_get_optional(cpu_dev, "cpu0");
> if (IS_ERR(cpu_reg)) {
> /*
> * If cpu0 regulator supply node is present, but regulator is
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2013-08-13 13:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 18:08 [PATCH] cpufreq: cpufreq-cpu0: Use devm_regulator_get_optional() Mark Brown
2013-08-12 5:22 ` Viresh Kumar
2013-08-12 10:01 ` Mark Brown
2013-08-13 13:07 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3483292.v6fTkTpAqi@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=cpufreq@vger.kernel.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox