From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v2] cpufreq: Don't use smp_processor_id() in preemptible context Date: Thu, 29 Aug 2013 22:31:19 +0200 Message-ID: <3563046.VrjExr8Wi1@vostro.rjw.lan> References: <521E24CE.9090407@codeaurora.org> <1377725085-16798-1-git-send-email-sboyd@codeaurora.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Viresh Kumar Cc: Stephen Boyd , Linux Kernel Mailing List , "cpufreq@vger.kernel.org" , "linux-pm@vger.kernel.org" On Thursday, August 29, 2013 09:50:22 AM Viresh Kumar wrote: > On 29 August 2013 02:54, Stephen Boyd wrote: > > Workqueues are preemptible even if works are queued on them with > > queue_work_on(). Let's use raw_smp_processor_id() here to silence > > the warning. > > > > BUG: using smp_processor_id() in preemptible [00000000] code: kworker/3:2/674 > > caller is gov_queue_work+0x28/0xb0 > > CPU: 0 PID: 674 Comm: kworker/3:2 Tainted: G W 3.10.0 #30 > > Workqueue: events od_dbs_timer > > [] (unwind_backtrace+0x0/0x11c) from [] (show_stack+0x10/0x14) > > [] (show_stack+0x10/0x14) from [] (debug_smp_processor_id+0xbc/0xf0) > > [] (debug_smp_processor_id+0xbc/0xf0) from [] (gov_queue_work+0x28/0xb0) > > [] (gov_queue_work+0x28/0xb0) from [] (od_dbs_timer+0x108/0x134) > > [] (od_dbs_timer+0x108/0x134) from [] (process_one_work+0x25c/0x444) > > [] (process_one_work+0x25c/0x444) from [] (worker_thread+0x200/0x344) > > [] (worker_thread+0x200/0x344) from [] (kthread+0xa0/0xb0) > > [] (kthread+0xa0/0xb0) from [] (ret_from_fork+0x14/0x3c) > > > > Signed-off-by: Stephen Boyd > > --- > > drivers/cpufreq/cpufreq_governor.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > Acked-by: Viresh Kumar Queued up for 3.12, thanks! -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.