From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH] cpufreq: arm-big-little: Make driver dependent on CONFIG_BIG_LITTLE Date: Mon, 06 Jan 2014 02:08:21 +0100 Message-ID: <39696841.2xGCnmPGdl@vostro.rjw.lan> References: Mime-Version: 1.0 Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-pm-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Viresh Kumar Cc: linaro-kernel@lists.linaro.org, patches@linaro.org, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux@arm.linux.org.uk On Friday, January 03, 2014 03:51:39 PM Viresh Kumar wrote: > arm_big_little cpufreq driver is only used for ARM bigLITTLE platforms and hence > must be dependent on CONFIG_BIG_LITTLE. > > This was highlighted by Russell earlier when he reported this issue: > > drivers/built-in.o: In function `bL_cpufreq_set_rate': > powercap_sys.c:(.text+0x5ed9a0): undefined reference to `bL_switch_request_cb' > > Reported-by: Russell King > Signed-off-by: Viresh Kumar Queued up for 3.14, thanks! > --- > drivers/cpufreq/Kconfig.arm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index 456ba5e..3275e9c 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -4,7 +4,7 @@ > > config ARM_BIG_LITTLE_CPUFREQ > tristate "Generic ARM big LITTLE CPUfreq driver" > - depends on ARM && ARM_CPU_TOPOLOGY && HAVE_CLK > + depends on ARM && BIG_LITTLE && ARM_CPU_TOPOLOGY && HAVE_CLK > select PM_OPP > help > This enables the Generic CPUfreq driver for ARM big.LITTLE platforms. > -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center.