From: Eric Piel <Eric.Piel@tremplin-utc.net>
To: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Dave Jones <davej@redhat.com>
Cc: CPUFreq Mailing List <cpufreq@lists.linux.org.uk>
Subject: [PATCH] keep ignore_nice_load value when the ondemand govenor is reselected
Date: Fri, 10 Mar 2006 11:35:27 +0200 [thread overview]
Message-ID: <4411485F.1010401@tremplin-utc.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 950 bytes --]
Hello,
With the ondemand governor, ignore_nice_load is reset each time the
governor is selected. That's annoying because each time I change to
another governor and change back to ondemand, I also have to set up
ignore_nice_load. eg:
# cat /sys/devices/system/cpu/cpu0/cpufreq/ondemand/ignore_nice_load
1
# cpufreq-set -g powersave
# cpufreq-set -g ondemand
# cat /sys/devices/system/cpu/cpu0/cpufreq/ondemand/ignore_nice_load
0
This behavior is also inconsistent with the other variables of
/sys/devices/system/cpu/cpu0/cpufreq/ondemand/
Attached is a patch that corrects the behavior.
see you,
Eric
---
From: Eric Piel <eric.piel@tremplin-utc.net>
Keep the value of ignore_nice_load of the ondemand governor even after
the governor has been deselected and selected back. This is the behavior
of the other exported values of the ondemand governor and it's much more
user-friendly.
Signed-off-by: Eric Piel <eric.piel@tremplin-utc.net>
[-- Attachment #2: cpufreq-ondemand-keep-ignore-nice-load-setting-2.6.16.patch --]
[-- Type: text/x-patch, Size: 698 bytes --]
--- linux-2.6.16-rc5.bak/drivers/cpufreq/cpufreq_ondemand.c 2006-03-03 22:10:26.000000000 +0100
+++ linux-2.6.16-rc5/drivers/cpufreq/cpufreq_ondemand.c 2006-03-03 21:58:58.000000000 +0100
@@ -84,6 +84,7 @@ struct dbs_tuners {
static struct dbs_tuners dbs_tuners_ins = {
.up_threshold = DEF_FREQUENCY_UP_THRESHOLD,
.sampling_down_factor = DEF_SAMPLING_DOWN_FACTOR,
+ .ignore_nice = 0,
};
static inline unsigned int get_cpu_idle_time(unsigned int cpu)
@@ -431,8 +432,6 @@ static int cpufreq_governor_dbs(struct c
def_sampling_rate = MIN_STAT_SAMPLING_RATE;
dbs_tuners_ins.sampling_rate = def_sampling_rate;
- dbs_tuners_ins.ignore_nice = 0;
-
dbs_timer_init();
}
[-- Attachment #3: Type: text/plain, Size: 147 bytes --]
_______________________________________________
Cpufreq mailing list
Cpufreq@lists.linux.org.uk
http://lists.linux.org.uk/mailman/listinfo/cpufreq
next reply other threads:[~2006-03-10 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-10 9:35 Eric Piel [this message]
2006-03-23 7:26 ` [PATCH] keep ignore_nice_load value when the ondemand govenor is reselected Eric Piel
-- strict thread matches above, loose matches on Subject: below --
2006-03-23 13:41 Pallipadi, Venkatesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4411485F.1010401@tremplin-utc.net \
--to=eric.piel@tremplin-utc.net \
--cc=cpufreq@lists.linux.org.uk \
--cc=davej@redhat.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox