From: Guillaume Chazarain <guichaz@yahoo.fr>
To: "Pallipadi, Venkatesh" <venkatesh.pallipadi@intel.com>
Cc: cpufreq@lists.linux.org.uk, davej@redhat.com
Subject: [PATCH] Uninitialized use of cmd.val in arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c:acpi_cpufreq_target()
Date: Tue, 02 Jan 2007 19:58:13 +0100 [thread overview]
Message-ID: <459AAB45.2000909@yahoo.fr> (raw)
In-Reply-To: <EB12A50964762B4D8111D55B764A8454010D1506@scsmsx413.amr.corp.intel.com>
[-- Attachment #1: Type: text/plain, Size: 52 bytes --]
Fix for uninitialized use.
Thanks.
--
Guillaume
[-- Attachment #2: acpi-cpufreq-uninitialized-cmd_val.diff --]
[-- Type: text/x-patch, Size: 678 bytes --]
cmd.val was used uninitialized on the line below.
Signed-off-by: Guillaume Chazarain <guichaz@yahoo.fr>
Acked-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
---
diff -r 90710ed1291f arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c
--- a/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c Mon Jan 01 01:00:04 2007 +0000
+++ b/arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c Tue Jan 02 16:27:47 2007 +0100
@@ -420,6 +420,7 @@ static int acpi_cpufreq_target(struct cp
msr =
(u32) perf->states[next_perf_state].
control & INTEL_MSR_RANGE;
+ cmd.val = get_cur_val(online_policy_cpus);
cmd.val = (cmd.val & ~INTEL_MSR_RANGE) | msr;
break;
case SYSTEM_IO_CAPABLE:
[-- Attachment #3: Type: text/plain, Size: 147 bytes --]
_______________________________________________
Cpufreq mailing list
Cpufreq@lists.linux.org.uk
http://lists.linux.org.uk/mailman/listinfo/cpufreq
prev parent reply other threads:[~2007-01-02 18:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-02 15:49 Uninitialized use of cmd.val in arch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c:423 Guillaume Chazarain
2007-01-02 17:57 ` Uninitialized use of cmd.val inarch/i386/kernel/cpu/cpufreq/acpi-cpufreq.c:423 Pallipadi, Venkatesh
2007-01-02 18:58 ` Guillaume Chazarain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=459AAB45.2000909@yahoo.fr \
--to=guichaz@yahoo.fr \
--cc=cpufreq@lists.linux.org.uk \
--cc=davej@redhat.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox