From mboxrd@z Thu Jan 1 00:00:00 1970 From: Santosh Shilimkar Subject: Re: [PATCH 3/3] cpufreq: Remove unnecessary use of policy->shared_type Date: Fri, 1 Feb 2013 12:17:44 +0530 Message-ID: <510B6510.6060608@ti.com> References: <1bf82454ab1f16b13212548d7c9605067c8b7a0d.1359700705.git.viresh.kumar@linaro.org> <902bed453159832925df76e24806f3b919fdfc74.1359700706.git.viresh.kumar@linaro.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <902bed453159832925df76e24806f3b919fdfc74.1359700706.git.viresh.kumar@linaro.org> Sender: linux-pm-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Viresh Kumar Cc: rjw@sisk.pl, cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-dev@lists.linaro.org, robin.randhawa@arm.com, Steve.Bannister@arm.com, Liviu.Dudau@arm.com, Linus Walleij , Stephen Warren , Shawn Guo On Friday 01 February 2013 12:10 PM, Viresh Kumar wrote: > policy->shared_type field was added only for SoCs with ACPI support: > > commit 3b2d99429e3386b6e2ac949fc72486509c8bbe36 > Author: Venkatesh Pallipadi > Date: Wed Dec 14 15:05:00 2005 -0500 > > P-state software coordination for ACPI core > > http://bugzilla.kernel.org/show_bug.cgi?id=5737 > > Many non-ACPI systems are filling this field by mistake, which makes its usage > confusing. Lets clean it. > > Signed-off-by: Viresh Kumar > Cc: Linus Walleij > Cc: Stephen Warren > Cc: Shawn Guo > Cc: Santosh Shilimkar > --- I haven't looked at the cpufreq code recently but remember that it was needed to ensure that all the CPU which share clock/voltage gets updated (affected cpus) on freq change. The CPUs which needs SW co-ordination, should have this flag enabled and OMAP was falling in that category. May be I miss-understood its use, but can you confirm that SW co-ordination logic continues to work without this flag ? Regards, Santosh