From: Dirk Brandewie <dirk.brandewie@gmail.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: dirk.brandewie@gmail.com, linux-kernel@vger.kernel.org,
cpufreq@vger.kernel.org,
Dirk Brandewie <dirk.j.brandewie@intel.com>
Subject: Re: [PATCH 2/7] cpufreq: Retrieve current frequency from scaling drivers with internal governors
Date: Tue, 05 Feb 2013 18:15:54 -0800 [thread overview]
Message-ID: <5111BCDA.1060507@gmail.com> (raw)
In-Reply-To: <CAOh2x=nYOf32jKqwwikgBS2oRHwmhZdVug=pLzQZWp-N2S9CGw@mail.gmail.com>
On 02/05/2013 05:45 PM, Viresh Kumar wrote:
> On Tue, Feb 5, 2013 at 11:54 PM, <dirk.brandewie@gmail.com> wrote:
>> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
>> index 2817c3c..96bc302 100644
>> --- a/drivers/cpufreq/cpufreq.c
>> +++ b/drivers/cpufreq/cpufreq.c
>> @@ -1181,6 +1181,13 @@ unsigned int cpufreq_quick_get(unsigned int cpu)
>> struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
>> unsigned int ret_freq = 0;
>>
>> + if (cpufreq_driver && cpufreq_driver->setpolicy &&
>> + cpufreq_driver->get) {
>> + ret_freq = cpufreq_driver->get(cpu);
>> + cpufreq_cpu_put(policy);
>> + return ret_freq;
>> + }
>> +
>
How about this?
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 2817c3c..9c0eac4 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1182,7 +1182,12 @@ unsigned int cpufreq_quick_get(unsigned int cpu)
unsigned int ret_freq = 0;
if (policy) {
- ret_freq = policy->cur;
+ if (cpufreq_driver && cpufreq_driver->setpolicy &&
+ cpufreq_driver->get) {
+ ret_freq = cpufreq_driver->get(cpu);
+ } else {
+ ret_freq = policy->cur;
+ }
cpufreq_cpu_put(policy);
}
next prev parent reply other threads:[~2013-02-06 2:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 18:23 [PATCH 0/7] Add P state driver for Intel Core Processors dirk.brandewie
2013-02-05 18:24 ` [PATCH 1/7] cpufreq: Don't remove sysfs link for policy->cpu dirk.brandewie
2013-02-06 1:42 ` Viresh Kumar
2013-02-05 18:24 ` [PATCH 2/7] cpufreq: Retrieve current frequency from scaling drivers with internal governors dirk.brandewie
2013-02-06 1:41 ` Viresh Kumar
2013-02-06 1:45 ` Viresh Kumar
2013-02-06 2:15 ` Dirk Brandewie [this message]
2013-02-06 2:25 ` Viresh Kumar
2013-02-06 2:31 ` Dirk Brandewie
2013-02-06 2:46 ` Viresh Kumar
2013-02-05 18:24 ` [PATCH 3/7] cpufreq: Only query drivers that implement cpufreq_driver.target() dirk.brandewie
2013-02-06 1:47 ` Viresh Kumar
2013-02-06 2:06 ` Dirk Brandewie
2013-02-06 2:43 ` Viresh Kumar
2013-02-05 18:24 ` [PATCH 4/7] cpufreq: Do not track governor name for scaling drivers with internal governors dirk.brandewie
2013-02-06 1:50 ` Viresh Kumar
2013-02-05 18:24 ` [PATCH 5/7] cpufreq: balance out cpufreq_cpu_{get,put} for scaling drivers using setpolicy dirk.brandewie
2013-02-06 1:58 ` Viresh Kumar
2013-02-06 2:08 ` Dirk Brandewie
2013-02-06 2:45 ` Viresh Kumar
2013-02-06 16:11 ` Dirk Brandewie
2013-02-06 16:19 ` Viresh Kumar
2013-02-05 18:24 ` [PATCH 6/7] cpufreq_stats: do not remove sysfs files if frequency table is not present dirk.brandewie
2013-02-06 2:18 ` Viresh Kumar
2013-02-05 18:24 ` [PATCH 7/7] cpufreq/x86: Add P-state driver for sandy bridge dirk.brandewie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5111BCDA.1060507@gmail.com \
--to=dirk.brandewie@gmail.com \
--cc=cpufreq@vger.kernel.org \
--cc=dirk.j.brandewie@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox