From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benoit Cousson Subject: Re: [PATCH 2/2] cpufreq: cpufreq-cpu0: provide compatibility string for DT matchup Date: Tue, 12 Mar 2013 15:28:40 +0100 Message-ID: <513F3B98.6050909@ti.com> References: <1363043130-30270-1-git-send-email-nm@ti.com> <1363043130-30270-3-git-send-email-nm@ti.com> <513EB7FE.1070000@ti.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <513EB7FE.1070000@ti.com> Sender: linux-omap-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii" To: Santosh Shilimkar , Nishanth Menon Cc: linux-pm@vger.kernel.org, "devicetree-discuss@lists.ozlabs.org" , linux-kernel@vger.kernel.org, cpufreq , "Rafael J. Wysocki" , linux-omap@vger.kernel.org On 03/12/2013 06:07 AM, Santosh Shilimkar wrote: > On Tuesday 12 March 2013 04:35 AM, Nishanth Menon wrote: >> commit 5553f9e (cpufreq: instantiate cpufreq-cpu0 as a platform_driver) >> now forces platform device to be registered for allowing cpufreq-cpu0 >> to be used by SoCs. example: drivers/cpufreq/highbank-cpufreq.c >> >> However, for SoCs that wish to link up using device tree, instead >> of platform device, provide compatibility string match: >> compatible = "cpufreq,cpu0"; You cannot add a non-HW relative binding... DT is supposed to represent the pure HW. AFAIK, cpufreq has nothing to do with the HW definition. >> >> Cc: "Rafael J. Wysocki" >> Cc: Santosh Shilimkar >> Cc: Shawn Guo >> Cc: linux-kernel@vger.kernel.org >> Cc: cpufreq@vger.kernel.org >> Cc: linux-pm@vger.kernel.org >> Cc: linux-omap@vger.kernel.org >> >> Signed-off-by: Nishanth Menon >> --- >> .../devicetree/bindings/cpufreq/cpufreq-cpu0.txt | 3 +++ >> drivers/cpufreq/cpufreq-cpu0.c | 6 ++++++ >> 2 files changed, 9 insertions(+) >> > Looks fine to me. CC'ing dt list in case some one has > comments on binding updates. > > Acked-by: Santosh Shilimkar Not-Acked-by-me. Regards, Benoit